Add hint and one-click copy for the three independent CLI-argument fields#5038
Open
Scott (7ranceaddic7) wants to merge 2 commits into
Open
Add hint and one-click copy for the three independent CLI-argument fields#5038Scott (7ranceaddic7) wants to merge 2 commits into
Scott (7ranceaddic7) wants to merge 2 commits into
Conversation
…tion logs UpdatePackageOperation and UninstallPackageOperation both logged their options dump under the header "Installation options:", inherited from InstallPackageOperation via copy-paste. Since InstallOptions.ToString() already renders CustomParameters_Install/_Update/_Uninstall separately by field name, this only affected the header text -- but it's actively misleading: users configuring a package's "Custom Install Arguments" field see that same value echoed under an "Installation options:" banner during an update run, which reads as confirmation that the install-time argument applies to updates too, even though it doesn't (CustomParameters_Update is the field that actually gets appended for update operations, per NpmPkgOperationHelper._getOperationParameters).
…elds Custom install/update/uninstall arguments are three separate fields with no indication that they're independent -- a user who fills in "Custom install arguments" (the field most naturally reached for first) has no signal that it won't be used for update or uninstall operations, only to discover it later via a failed update. This adds, on both the per-manager default-options panel and the per-package install-options dialog: - A short hint explaining the fields are independent - A "Copy install arguments to update and uninstall" link for users who do want the same flag applied everywhere, so they don't have to retype it three times
Author
|
Real-world verification of the scenario this PR is meant to prevent: The whole point of the hint + "Copy install arguments to update and uninstall" link is: once a user correctly populates
Done via a temporary local test calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5037. That PR fixed a misleading log label; this one addresses the underlying UX gap that caused the confusion in the first place.
CustomParameters_Install,CustomParameters_Update, andCustomParameters_Uninstallare three independent fields, shown as three separate rows on both the per-manager default-options settings panel (InstallOptionsPanel) and the per-package install-options dialog (InstallOptionsControl). Nothing on either screen indicates that these fields are independent -- a user reaching for "Custom install arguments" (the first row, and the one most naturally filled in first) has no signal that the same argument won't be applied on update or uninstall, and finds out only when an update fails for a reason that looks unrelated.Change, on both screens:
No behavior change to the underlying
InstallOptionsengine -- this only affects the two settings screens. New strings added tosrc/Languages/lang_en.jsonfollowing the existing convention (see e.g. #4902).Verified with
dotnet buildonUniGetUI.Avalonia.csproj(0 errors) against SDK 10.0.301 -- Avalonia's compiledx:DataTypebindings fail the build on any binding-name typo, so a clean build confirms the new bindings (CliArgsHintLabel,CopyInstallArgsLabel,CopyInstallArgsToOthersCommand) resolve correctly on both views.N/A. No existing issue tracks this; not creating one per the PR template guidance.