fix(rdpsnd-native)!: replace anyhow with typed RdpsndNativeError

[Greg Lamberson (glamberson)]

Summary

Replaces anyhow::Result on DecodeStream::new with a typed
RdpsndNativeError, bringing the crate into line with the workspace
convention from ARCHITECTURE.md that libraries provide concrete
error types rather than anyhow.

Approach

• New error module defines RdpsndNativeErrorKind with four variants
  (UnsupportedFormat, OpusInit, AudioDevice, StreamBuild).
  Display and core::error::Error impls are hand-rolled, following
  the post-refactor(pdu): hand-roll Display/Error impls and remove thiserror dependency #1264 pattern in ironrdp-pdu.
• Type alias RdpsndNativeError = ironrdp_error::Error<RdpsndNativeErrorKind>
  keeps the workspace's Error<Kind> shape.
• DecodeStream::new returns RdpsndNativeResult<Self> instead of
  anyhow::Result<Self>. Foreign error sources (opus2::Error,
  cpal::DefaultStreamConfigError, cpal::BuildStreamError) attach
  via Error::with_source so the cause chain stays reachable through
  core::error::Error::source().
• anyhow moves from [dependencies] to [dev-dependencies] for the
  cpal example binary.

Alternatives considered

• thiserror derive: rejected for consistency with the post-refactor(pdu): hand-roll Display/Error impls and remove thiserror dependency #1264
  direction in ironrdp-pdu. ironrdp-rdpsnd-native is not Core Tier
  and could technically use thiserror, but staying hand-rolled
  matches the recently-established workspace pattern.
• Wrap source errors inside the kind enum (the ConnectorErrorKind
  style): rejected because the source types (opus2::Error, multiple
  cpal errors) would leak into the public Kind surface for
  marginal matchability benefit.
• Keep anyhow internally, change only the public signature:
  rejected because anyhow::Error would still propagate through the
  source chain to consumers.

Trade-offs accepted

The four-variant categorisation is coarser than per-error-type
matchability would offer. Consumers needing finer detail traverse the
source chain via core::error::Error::source(). This matches the
existing pattern in PduErrorKind.

Verification

• cargo xtask check fmt -v green
• cargo xtask check lints -v green
• cargo xtask check tests -v green
• cargo xtask check typos -v green
• cargo xtask check locks -v green
• cargo check -p ironrdp-rdpsnd-native --no-default-features green
• cargo check -p ironrdp-rdpsnd-native --examples green

References

• Pattern: refactor(pdu): hand-roll Display/Error impls and remove thiserror dependency #1264 (hand-roll Display/Error in ironrdp-pdu).
• bail! macro: feat(error): add shared bail! and ensure! macros to ironrdp-error #1263 (shared macros in ironrdp-error).

[Benoît Cortier (CBenoit)]

LGTM!

[Copilot]

Pull request overview

This PR updates ironrdp-rdpsnd-native to expose a concrete, typed error (RdpsndNativeError) instead of returning anyhow::Result from DecodeStream::new, aligning the crate with the workspace convention of library crates providing typed error surfaces.

Changes:

• Introduces RdpsndNativeErrorKind and associated RdpsndNativeError/RdpsndNativeResult aliases.
• Switches DecodeStream::new (and related call sites) from anyhow-based errors to ironrdp_error::Error<Kind> with optional chained sources.
• Moves anyhow to dev-dependencies (kept for the example) and updates logging to use e.report().

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/ironrdp-rdpsnd-native/src/lib.rs	Exposes the new typed error module/types; keeps anyhow referenced under cfg(test).
crates/ironrdp-rdpsnd-native/src/error.rs	Adds the new typed error kind and type aliases.
crates/ironrdp-rdpsnd-native/src/cpal.rs	Converts DecodeStream::new to typed errors and attaches sources; updates logging.
crates/ironrdp-rdpsnd-native/Cargo.toml	Replaces anyhow dependency with ironrdp-error (std) and moves anyhow to dev-deps.
Cargo.lock	Adds ironrdp-error to the lockfile dependency graph.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.