fix(cliprdr)!: receiving a TemporaryDirectory PDU should not fail the svc #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvcProcessorimpl. to support handling aTemporaryDirectoryClipboard PDU.ClipboardError::UnimplementedPdusince it is no longer usedWithout this fix, I was unable to get the
ironrdp-servercrate to work with my customCliprdrBackendimpl. This change makes sense since this PDU is a valid clipboard PDU that we should process and is (optionally) sent by an RDP client. I've chosen not to add a callback in theCliprdrBackendtrait since this PDU seems useless as there is nothing todo with it from theironrdp-server's perspective.