Cleanup #65
Merged
Cleanup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate to say it, but I'm pretty sure it's a toml_edit choice. When they format an I vaguely remember this was one of the things that slowed me WAY down working on this. There isn't really a good answer. When do we add newlines when seeing any suffix decor with a newline? Does adding a line length option make sense (thinking about tracking line length is when I took a break on cargo sort haha) it would make the decision of newlines or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29, I failed to do a proper manual test before merging. This fixes the biggest problems things from that PR. Arrays (of strings) seem to still be re-formatted from multiline to single-line, I hope that's a bug here and not in toml_edit, so it can easily be fixed before the next release.