refactor: change all the println! to log #41
ci.yml
on: pull_request
stable / fmt
11s
nightly / doc
22s
ubuntu / stable / coverage
37s
Spell Check
4s
Matrix: clippy
Matrix: os-check
Matrix: required
Annotations
5 warnings
you should consider adding a `Default` implementation for `LR0ItemSet<'grammar>`:
src/lr0/core.rs#L124
warning: you should consider adding a `Default` implementation for `LR0ItemSet<'grammar>`
--> src/lr0/core.rs:124:5
|
124 | / pub fn new() -> Self {
125 | | Self {
126 | | items: HashSet::new(),
127 | | }
128 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
123 + impl<'grammar> Default for LR0ItemSet<'grammar> {
124 + fn default() -> Self {
125 + Self::new()
126 + }
127 + }
|
|
this lifetime isn't used in the function definition:
src/lr0/core.rs#L55
warning: this lifetime isn't used in the function definition
--> src/lr0/core.rs:55:23
|
55 | pub fn transition<'a>(&self, from: usize, via: &Term) -> Option<usize> {
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
|
struct `LR0Closure` has a public `len` method, but no `is_empty` method:
src/lr0/core.rs#L51
warning: struct `LR0Closure` has a public `len` method, but no `is_empty` method
--> src/lr0/core.rs:51:5
|
51 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
unused import: `std::str::FromStr`:
src/slr/builder.rs#L12
warning: unused import: `std::str::FromStr`
--> src/slr/builder.rs:12:5
|
12 | use std::str::FromStr;
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
stable / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|