Fixed #140 -- Added route inject config validation before route registration.#172
Merged
Merged
Conversation
Greptile SummaryThis PR moves route
|
| Filename | Overview |
|---|---|
| src/quater/_route_definition.py | Centralizes inject validation in the shared route-definition builder. |
| src/quater/groups.py | Removes duplicate route-level inject normalization from RouteGroup.add_route(). |
| tests/unit/test_app_config.py | Adds app-level tests for invalid inject names and non-Resource values. |
| docs/en/dev/resources.md | Documents registration-time validation for route inject maps. |
| docs/en/dev/changelog.md | Records the route inject validation timing change. |
Reviews (6): Last reviewed commit: "Fixed #140 -- Added route inject config ..." | Re-trigger Greptile
DevilsAutumn
reviewed
Jul 8, 2026
DevilsAutumn
left a comment
Owner
There was a problem hiding this comment.
@utk2103 Thanks, just a small correction, rest everything looks correct.
DevilsAutumn
requested changes
Jul 9, 2026
… route registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quater.add_route()now validates inject names/values at add time by routing throughnormalize_inject()insidebuild_route_definition(), matchingRouteGroup's existing behavior.normalize_inject()call inRouteGroup.add_route()since validation now lives in the shared builder.Resourceinject values onQuater.add_route().docs/en/dev/resources.mdand recorded the change indocs/en/dev/changelog.md.Linked Issue
Fixes #140
Contributor Checklist
acceptedbefore I started.issue_{issue_number}.Checks Run
uv run pytest tests/unit/test_app_config.py -k "inject" -x— 2 passeduv run pytest tests/unit/test_route_group.py tests/unit/test_app_config.py— 131 passeduv run pytest tests/unit— 905 passed