Skip to content

improve saml authentication #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

denis99999
Copy link

fixes #835

Signed-off-by: Denis barbaron <denis.barbaron@orange.com>
@denis99999
Copy link
Author

@koral-- please wait before merging, so that @jupe can test it with the Google configuration

@jupe
Copy link

jupe commented Feb 18, 2025

Is docker image available somewhere?

@denis99999
Copy link
Author

@koral-- can you merge this PR, it keeps the default behavior so no danger, and so @jupe will be able to access the generated Docker image

@denis99999 denis99999 requested a review from koral-- February 18, 2025 17:51
@koral-- koral-- merged commit 1e30690 into DeviceFarmer:master Feb 18, 2025
2 checks passed
@jupe
Copy link

jupe commented Feb 19, 2025

Verified and now we were able to use google SAML with args;

- SAML_ID_PROVIDER_WANT_ASSERTIONS_SIGNED=false
- SAML_ID_PROVIDER_WANT_AUTHN_RESPONSE_SIGNED=true

@koral-- could you create release ?

michal-murin pushed a commit to wandera/devicefarmer-stf that referenced this pull request Feb 28, 2025
Signed-off-by: Denis barbaron <denis.barbaron@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google SAML app combatibility broken
3 participants