Skip to content

improve device state consistency #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

denis99999
Copy link

answer to #830

Signed-off-by: Denis barbaron <denis.barbaron@orange.com>
@koral-- koral-- merged commit edb3892 into DeviceFarmer:master Feb 4, 2025
2 checks passed
@Igorshp
Copy link

Igorshp commented Feb 4, 2025

Thanks! that was super quick!

Got a small question: would the statusChangedAt also need be set to the same value from the message, instead of being generated in the database? The stateChanged checks do verify this field as well.

https://github.com/denis99999/stf/blob/f4edd8b87877871bbbe8098ac86cd43a760f83f6/lib/db/api.js#L1176

@denis99999
Copy link
Author

No need, let me know if this PR fixes your issue?

michal-murin pushed a commit to wandera/devicefarmer-stf that referenced this pull request Feb 28, 2025
Signed-off-by: Denis barbaron <denis.barbaron@orange.com>
Co-authored-by: Karol Wrótniak <karol.wrotniak@droidsonroids.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants