fix: clamp negative times with go uci command
#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn on the `clamp-negatives` feature for the uci-parser so that negative values do not throw an error in the engine. Resolves #100 bench: 2517656
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 48 48
Lines 7800 7800
=======================================
Hits 6523 6523
Misses 1277 1277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
SPRT Regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on the
clamp-negativesfeature for the uci-parser so that negative values do not throw an error in the engine.Resolves #100
bench: 2517656