Add inline form validation to Web Auth #232
Conversation
- Implemented field-level validation for Auth page - Added `noValidate` to form to prevent native browser bubbles - Integrated validation errors with `Input` component styling - Verified via Playwright test with strict selector handling
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Deploy Preview for split-but-wiser canceled.
|
for more information, see https://pre-commit.ci
Implemented inline form validation for the Web Auth page. This improves the user experience by providing immediate feedback for invalid inputs (empty fields, invalid email format, short passwords) without waiting for a server response or relying on inconsistent browser-native validation bubbles.
Key changes:
web/pages/Auth.tsx: AddedfieldErrorsstate andvalidateFormlogic. AddednoValidateto the form to disable default HTML5 validation, allowing custom UI to take precedence.web/components/ui/Input.tsx: Verifiederrorprop support (logic already existed, just leveraged it).Verification:
verification/verify_auth_validation.py) to confirm that error messages appear correctly for various invalid states and clear upon correction.PR created automatically by Jules for task 9638339120034010440 started by @Devasy23