Skip to content

Conversation

@DevTKSS
Copy link
Owner

@DevTKSS DevTKSS commented Jun 28, 2025

  • Adding some Metadata to the Xaml NavigationApp, fitting the VS Launchsettings

WIP

  • Adding Navigation Docs Tutorial Content
  • Add or link code to the tutorial beside the current link to the source code - issue with docfx, not resolving code links

@DevTKSS DevTKSS marked this pull request as ready for review June 30, 2025 22:17
Copilot AI review requested due to automatic review settings June 30, 2025 22:17

This comment was marked as outdated.

@DevTKSS DevTKSS marked this pull request as draft June 30, 2025 22:28
Repository owner deleted a comment from Copilot AI Jul 8, 2025
@DevTKSS DevTKSS marked this pull request as ready for review July 8, 2025 20:46
@DevTKSS DevTKSS requested a review from Copilot July 8, 2025 20:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enriches the XamlNavigationApp documentation by adding localized English and German tutorials with YouTube links, updates project and IDE launch configurations to support the new sample, and cleans up solution and package settings.

  • Add ReadMe.en.md and ReadMe.de.md under XamlNavigationApp with links to YouTube tutorials
  • Update launchSettings.json, VS Code tasks.json/launch.json, and solution to configure and debug the XamlNavigationApp
  • Extend documentation TOC, docfx settings, and remove the old ReadMe.md placeholder

Reviewed Changes

Copilot reviewed 71 out of 101 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Directory.Packages.props Remove stray trailing whitespace
src/DevTKSS.Uno.XamlNavigationApp-1/ReadMe.* Remove old ReadMe.md; add localized English/German docs with tutorial links
src/DevTKSS.Uno.XamlNavigationApp-1/Properties/launchSettings.json Fix commandLineArgs to point at the correct DLL
src/DevTKSS.Uno.Samples.sln Add Debug/Release configurations for x64 and x86
src/.vscode/tasks.json & src/.vscode/launch.json Add build/publish tasks and launch configs for XamlNavigationApp
doc/toc.yml & doc/articles/** Update table-of-contents entries, metadata, and add new tutorial markdown files
src/DevTKSS.Uno.Samples.MvuxGallery/Presentation/ViewModels/MainModel.cs Add unused private field _stringLocalizer without constructor injection
Comments suppressed due to low confidence (2)

src/DevTKSS.Uno.Samples.MvuxGallery/Presentation/ViewModels/MainModel.cs:5

  • The _stringLocalizer field is declared but never assigned or used. Consider injecting it via the constructor or removing it if it's not needed.
    private readonly IStringLocalizer _stringLocalizer;

next part could be to show the csharp code way to do this or implementing the TabBar from the MvuxGallery app
chore: fix most of the docfx warnings, 17 left

BUG: Uno.Resizetizer is getting shown as part of the API, which is not correct.
BUG: Logo is not shown correctly, same as the video elements sourced from YouTube.
BUG: Still the landing page is not publishable as the topicHref is not working for this
DevTKSS and others added 11 commits October 25, 2025 17:27
chore: change location of Navigation Intro

chore: try add codebasePath but still not able to resolve the paths needed

Will solve with copy pasting the appropriate code but should not be the target using docfx!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@DevTKSS DevTKSS force-pushed the Update-Xaml-NavigationApp-with-metadata branch from ada6db7 to 5a29193 Compare October 25, 2025 15:49
@DevTKSS DevTKSS merged commit c0344e6 into master Oct 25, 2025
@github-project-automation github-project-automation bot moved this from Tackle me! to Done in @DevTKSS Bug Tracker Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants