Fix context switch workflow and pipeline calls order #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevNatan
changed the title
DevNatan
changed the title
DevNatan
commented
Mar 21, 2025
Comment on lines
+88
to
+94
| for (final Viewer viewer : renderContext.getIndexedViewers().values()) { | ||
| setupViewer(viewer, renderContext, root); | ||
| } | ||
|
|
||
| final Viewer viewer = renderContext.getViewer(); | ||
| if (viewer != null) setupViewer(viewer, renderContext, root); | ||
|
|
There was a problem hiding this comment.
This code opens support to include players in the context of another player without needing to added then through open(...).
nicolube
reviewed
Mar 21, 2025
|
|
||
| @Override | ||
| public void onFirstRender(@NotNull RenderContext render) { | ||
| render.slot(1, new ItemStack(Material.DIAMOND)).onClick(click -> click.openForPlayer(SimplePagination.class)); |
There was a problem hiding this comment.
Maybe we also should test the other way around, when this view is opened by another without using back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in samples, debugs we're displaying the wrong values for "Viewer added to..." and "Viewer removed from...", when switching contexts the context shown in "Viewer added" and "Viewer removed" debugs were the same (which is wrong);
getPreviousContextmust ensure thatisSwitchingto true in Viewer APIPlatformView#onViewerAddedand pipelineVIEWER_ADDED/VIEWER_REMOVEDcalls order.getCurrentContextthat ensures context consistency when switching from a context to another.isSwitchingreset once a player is switched successfully to the next context.onViewerAddedis also called when switching back to a context (onViewerAdded -> onResume).With all the changes, when switching back to a context (
context.back()) state values of that context will be kept. I'll address it in the next PR. For now you need to manually reset (if you want) viaonResume.Fixes #696; Fixes #658; Fixes #657; Fixes #649; Fixes #647; Fixes #383