-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bitbucket pipelines sample for firefox #8274
base: master
Are you sure you want to change the base?
Conversation
I don't understand what this means in the list of steps that showed up on the PR. Is this something I need to do? Request Deployment / authenticate (pull_request_target) Waiting |
Hello @adityai, Thank you for your pull request. The |
Purpose
The example for running test cafe on bitbucket cloud is outdated. The image circleci/node:10.14-browsers is outdated and does not work for the latest version of testcafe.
Approach
CircleCI has a newer version of node container images hosted as cimg/node, for the latest versions of node that is compatible with the latest version of testcafe. The image 'cimg/node:current-browsers' has the latest version of node installed in it. I was expecting browsers to be already installed in it but it was missing the browsers. Installing chrome using wget and apt-get did not quite work out and other dependencies may be required. If I figure it out, I will submit a separate PR for updating the chrome example. Installing firefox using wget was a lot more straightforward. So, I created a copy of the chrome example, edited it for running the tests using firefox and edited bitbucket-pipelines.yml to install firefox before running the tests.
References
[cimg/node:current-browsers] https://hub.docker.com/layers/cimg/node/current-browsers/images/sha256-c250426a248f85446bd7639658ae30375b3c72481daa9744b242c054de11897f?context=explore
Pre-Merge TODO