fix: disableConcurrency with quarantine mode (closes #8087) #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
PavelMor25
removed
the
STATE: Need response
AlexKamaev
approved these changes
Nov 23, 2023
|
Release v3.5.0-rc.1 addresses this. |
1 similar comment
|
Release v3.5.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Disabling concurrency with quarantine mode led to unexpected behavior.
Approach
Updated method
_onTestRunRestartin browser job.Previously, we added a quarantine test to the general queue. Now we change the queue, if before this the test was executed in a fixture with the
disable concurrencyflag.References
#8087
Pre-Merge TODO