-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: debug with selector option added #8066
Conversation
…red DebugCommand and execute-client-function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Please look at my comments
src/client/ui/selector-inspector-panel/selector-input-container.js
Outdated
Show resolved
Hide resolved
test/functional/fixtures/ui/testcafe-fixtures/selector-inspector-test.js
Outdated
Show resolved
Hide resolved
test/functional/fixtures/ui/testcafe-fixtures/selector-inspector-test.js
Outdated
Show resolved
Hide resolved
test/functional/fixtures/ui/testcafe-fixtures/selector-inspector-test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing
src/client/ui/selector-inspector-panel/selector-input-container.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, merge after the tests turn green
Please, do not merge. We need add documentation first. |
Release v3.5.0-rc.1 addresses this. |
Release v3.5.0-rc.1 addresses this. |
Purpose
The purpose of this PR is to allow passing selector to a t.debug call. Something like this t.debug(Selector). Then the selector will be shown in debug mode and highlighted.
Approach
So overall, the main goal was to pass the selector argument from server-side debug call to client-side selector-input-contaner.
- remove any previously highlighted elements,
- get Selector name and assign it to this.value for SelectorInputContainer,
- execute Selector to get elements for highlighting and indication,
- highlight and indicate elements of the Selector
References
https://github.com/DevExpress/testcafe-private/issues/163
Pre-Merge TODO