Skip to content

refactor: removed IE and MS Edge Legacy leftovers from test\client\legacy-fixtures\api #7962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023
Merged

refactor: removed IE and MS Edge Legacy leftovers from test\client\legacy-fixtures\api #7962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d10ab
removed IE and MS Edge Legacy leftovers from test\client\legacy-fixtu…
Aleksey28 Aug 22, 2023
5e88620
fix: removed unnecessary imports
Aleksey28 Aug 22, 2023
3390797
refactor: removed unnecessary steps
Aleksey28 Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions test/client/legacy-fixtures/api/click-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,7 @@ $(document).ready(function () {
};

const startNext = function () {
if (browserUtils.isIE) {
removeTestElements();
window.setTimeout(start, 30);
}
else
start();
start();
};

const runAsyncTest = function (actions, assertions, timeout) {
Expand Down Expand Up @@ -147,8 +142,7 @@ $(document).ready(function () {
});

QUnit.testDone(function () {
if (!browserUtils.isIE)
removeTestElements();
removeTestElements();

SETTINGS.ENABLE_SOURCE_INDEX = false;
currentErrorType = null;
Expand Down
3 changes: 0 additions & 3 deletions test/client/legacy-fixtures/api/drag-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ const correctTestWaitingTime = function (time) {
};

$(document).ready(function () {
// NOTE: remove this after fix IE tests in iFrame
$('body').css('border', '0px');

// NOTE: prevent auto scrolling
if (browserUtils.isSafari && featureDetection.isTouchDevice) {
const $meta = $('<meta name="viewport" content="initial-scale=1.0, maximum-scale=1.0, shrink-to-fit=no">');
Expand Down
9 changes: 0 additions & 9 deletions test/client/legacy-fixtures/api/press-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const hammerhead = window.getTestCafeModule('hammerhead');
const browserUtils = hammerhead.utils.browser;
const iframeSandbox = hammerhead.sandbox.iframe;

const testCafeCore = window.getTestCafeModule('testCafeCore');
Expand Down Expand Up @@ -231,10 +230,6 @@ $(document).ready(function () {
iframe.contentDocument.body.appendChild(link);
link.focus();

// NOTE: we need setTimeout to wait for focus in IE
return wait(browserUtils.isIE ? 1000 : 0);
})
.then(function () {
equal(domUtils.getActiveElement(), iframe);
equal(domUtils.getActiveElement(iframe.contentDocument), link);

Expand Down Expand Up @@ -286,10 +281,6 @@ $(document).ready(function () {
iframe.contentDocument.body.appendChild(link);
link.focus();

// NOTE: we need setTimeout to wait for focus in IE
return wait(browserUtils.isIE ? 1000 : 0);
})
.then(function () {
equal(domUtils.getActiveElement(), iframe);
equal(domUtils.getActiveElement(iframe.contentDocument), link);

Expand Down
8 changes: 1 addition & 7 deletions test/client/legacy-fixtures/api/select-test/index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const hammerhead = window.getTestCafeModule('hammerhead');
const browserUtils = hammerhead.utils.browser;
const featureDetection = hammerhead.utils.featureDetection;

const testCafeCore = window.getTestCafeModule('testCafeCore');
Expand All @@ -21,7 +20,7 @@ const initAutomation = testCafeLegacyRunner.get('./init-automation');
initAutomation();

const correctTestWaitingTime = function (time) {
if (featureDetection.isTouchDevice || featureDetection.hasTouchPoints)
if (featureDetection.isTouchDevice)
return time * 2;

return time;
Expand Down Expand Up @@ -214,11 +213,6 @@ $(document).ready(function () {

$('body').css('height', '1500px');

//NOTE: problem with window.top bodyMargin in IE9 if test 'runAll'
//because we can't determine that element is in qunit test iframe
if (browserUtils.isIE9)
$(window.top.document).find('body').css('marginTop', '0px');

//tests
QUnit.testStart(function () {
asyncActionCallback = function () {
Expand Down