refactor: remove unused code from onBeforeWrite hook and remove context binding(closes testcafe-private#196) #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artem-Babich
force-pushed
the
refactor-on-before-write
branch
from
067a84d to
810f8d9
Compare
Artem-Babich
changed the title
Artem-Babich
force-pushed
the
refactor-on-before-write
branch
from
8d74e57 to
7bd7b0b
Compare
miherlosev
approved these changes
Jun 6, 2023
Artem-Babich
changed the title
|
Release v3.0.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove unused function
Remove context since it can break internal logic
References
https://github.com/DevExpress/testcafe-private/issues/196
Pre-Merge TODO