-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test and fixture info to the TestController object and fixture hooks(closes #2826) #7736
Conversation
4bf8617
to
af6de9d
Compare
177d4d0
to
23d65c9
Compare
Release v3.0.0-rc.1 addresses this. |
This breaks a lot of my tests because I use arrays, booleans, etc as data types as part of the meta object. For example: test.meta({ Now it expects all properties to be string values only. Is this expected? |
Hi @Makavelic, It is intended behavior. The documentation states that meta should have a string type. It was a bug before 3.0.0. Could you describe for what purpose you send an array as a value? |
My project has a custom testcafe runner that parses this value to determine whether a test should be skipped or not. An array is useful because I can add several conditions. I can refactor my runner code to just parse a string and split on ',' or something to get the desired effect. |
## Purpose Regression after #7736 ## Approach _Describe how your changes address the issue or implement the desired functionality in as much detail as possible._ ## References _Provide a link to the existing issue(s), if any._ ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail
Hi @Makavelic, Thank you for reporting this issue. We fixed it and published 3.0.0-rc.2 with this fix. |
Purpose
#2826
Currently, you cannot access any test/fixture information inside test and fixture hooks using public API. Fixture hooks cannot access this info even with private API.
Approach
Add corresponding members fixture: FixtureInfo, test:TestInfo to the TestController instance. Add the fixture info as a second argument to the fixture specific hooks.
References
#2826
API
Pre-Merge TODO