Remove the '--experimental-debug' feature #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksey28
requested changes
May 8, 2023
src/api/exportable-lib/index.js
Outdated
| @@ -76,7 +76,7 @@ const exportableLib = { | |||
| if (global[TEST_FILE_TEMP_VARIABLE_NAME]) { | |||
There was a problem hiding this comment.
As far as I know, TEST_FILE_TEMP_VARIABLE_NAME is needed only for the compiler service mode. So, you can remove this if-else block.
| @@ -154,10 +152,7 @@ export default class APIBasedTestFileCompilerBase extends TestFileCompilerBase { | |||
| if (APIBasedTestFileCompilerBase._isNodeModulesDep(filename) && hadGlobalAPI) | |||
| this._removeGlobalAPI(); | |||
|
|
|||
| if (this.isCompilerServiceMode) | |||
| this._compileExternalModuleInEsmMode(mod, filename, requireCompilers[ext], origExt); | |||
There was a problem hiding this comment.
You removed using this method, but you didn't remove this method from class
src/runner/bootstrapper.ts
Outdated
|
|
||
| const compiler = new Compiler(sourceList, compilerOptions, { baseUrl, isCompilerServiceMode: false, esm }); | ||
| private async _compileTests ({ sourceList, compilerOptions }: CompilerArguments): Promise<Test[]> { | ||
| const baseUrl = this.configuration.getOption(OPTION_NAMES.baseUrl) as string; |
src/test-run/index.ts
Outdated
| @@ -1280,7 +1168,7 @@ export default class TestRun extends AsyncEventEmitter { | |||
| // NOTE: In regular mode, it's possible to debug tests only using TestCafe UI ('Resume' and 'Next step' buttons). | |||
| // So, we should warn on trying to debug in headless mode. | |||
There was a problem hiding this comment.
I think, this comment is useless
Aleksey28
approved these changes
May 10, 2023
|
Release v2.6.1-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://testcafe.io/documentation/402639/reference/command-line-interface#--experimental-debug