-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server tests in Node v15 #5652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Tests for the commit 4e6ef6e have failed. See details: |
@testcafe-build-bot retest |
❌ Tests for the commit 4e6ef6e have failed. See details: |
❌ Tests for the commit 60c89ba have failed. See details: |
wentwrong
changed the title
[TEST] Trying to fix tests after upgrading to Node 15
Fix server tests in Node v15
Oct 22, 2020
❌ Tests for the commit 242021f have failed. See details: |
AndreyBelym
approved these changes
Oct 26, 2020
✅ Tests for the commit 242021f have passed. See details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js v15 adds a prefix to builtin module filenames in stacktraces: src: use node:moduleName as builtin module filename.
We need to take into account this change by adding one more case to our filtering logic of filenames in stacktraces.