Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server tests in Node v15 #5652

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

wentwrong
Copy link
Contributor

@wentwrong wentwrong commented Oct 22, 2020

Node.js v15 adds a prefix to builtin module filenames in stacktraces: src: use node:moduleName as builtin module filename.

We need to take into account this change by adding one more case to our filtering logic of filenames in stacktraces.

@testcafe-build-bot
Copy link
Collaborator

@wentwrong
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@wentwrong wentwrong changed the title [TEST] Trying to fix tests after upgrading to Node 15 Fix server tests in Node v15 Oct 22, 2020
@wentwrong wentwrong marked this pull request as ready for review October 22, 2020 18:48
@miherlosev miherlosev marked this pull request as draft October 26, 2020 06:51
@miherlosev miherlosev marked this pull request as ready for review October 26, 2020 08:36
@testcafe-build-bot
Copy link
Collaborator

@testcafe-build-bot
Copy link
Collaborator

@miherlosev miherlosev merged commit b5c870c into DevExpress:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants