Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Publish the Jenkins Plugin blog post #5329

Merged
merged 12 commits into from
Jul 28, 2020
Merged

[docs] Publish the Jenkins Plugin blog post #5329

merged 12 commits into from
Jul 28, 2020

Conversation

titerman
Copy link
Contributor

No description provided.

@titerman titerman requested a review from VasilyStrelyaev July 16, 2020 09:54
wentwrong
wentwrong reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@wentwrong wentwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost good for me, but it seem that paths to images are broken (I cannot see any of them when viewing .md file in github).

docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
@VasilyStrelyaev
Copy link
Collaborator

@wentwrong Unfortunately, images won't show when you view an .md file in a PR if it's a blog post.

Abadzhev
Abadzhev reviewed Jul 17, 2020
View reviewed changes
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
docs/articles/blog/2020-7-15-introducing-the-testcafe-jenkins-plugin.md Outdated Show resolved Hide resolved
titerman and others added 2 commits July 21, 2020 11:23
@titerman @Abadzhev
Apply suggestions from code review
f66ee0d 
Co-authored-by: Abadzhev <vladimira@devexpress.com>
@titerman
Addressed @Abadzhev's remarks
454a41c
@VasilyStrelyaev VasilyStrelyaev merged commit 684a548 into DevExpress:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertov05 albertov05 albertov05 left review comments

@Abadzhev Abadzhev Abadzhev left review comments

@wentwrong wentwrong wentwrong approved these changes

@VasilyStrelyaev VasilyStrelyaev VasilyStrelyaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@titerman @VasilyStrelyaev @Abadzhev @wentwrong @albertov05