[Multi browser window] Refactor pageId to windowId

[AndreyBelym]

IMHO pageId naming is not very self-describing. Actually, it's not a page ID, but a window ID, In some context it can cause confusion. E.g. when handling t.getBrowserConsoleMessages, console messages are recorded not for a page, but for a window (which can host a number of different pages during a test session).

[miherlosev]

There is the following terms conflict:
End-user opens a page in the browser tab. The page contains a few windows (top and in iframe). We open a page in a window instead of a tab.

The pageId name is not ideal. But in my opinion, the pageId is better than windowId. Because it allows avoiding confusion between different kinds of windows (window is a detached browser tab, a window is a place where the HTML document is displayed).

That do you think about it? @helen-dikareva @kirovboris

[miherlosev]

After the discussion, we decided to change the parameter name to windowId.

[lock]

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.