Handle unreachable pages + remove some tests from exceptions (#7490)

DevExpress · Feb 3, 2023 · af6cb5c · af6cb5c
1 parent f426301
commit af6cb5c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/gulp/constants/functional-test-globs.js b/gulp/constants/functional-test-globs.js
@@ -38,20 +38,13 @@ const PROXYLESS_TESTS_GLOB = [
     '!test/functional/fixtures/live/test.js',
     '!test/functional/fixtures/api/es-next/navigate-to-and-test-page/test.js',
     '!test/functional/fixtures/api/es-next/request/test.js',
-    '!test/functional/fixtures/regression/gh-1138/test.js',
     '!test/functional/fixtures/regression/gh-1311/test.js',
     '!test/functional/fixtures/regression/gh-1388/test.js',
-    '!test/functional/fixtures/regression/gh-1521/test.js',
-    '!test/functional/fixtures/regression/gh-1846/test.js',
-    '!test/functional/fixtures/regression/gh-2546/test.js',
-    '!test/functional/fixtures/regression/gh-2601/test.js',
     '!test/functional/fixtures/hammerhead/gh-2622/test.js',
     '!test/functional/fixtures/regression/gh-2861/test.js',
     '!test/functional/fixtures/regression/gh-3127/test.js',
     '!test/functional/fixtures/regression/gh-423/test.js',
-    '!test/functional/fixtures/regression/gh-5447/test.js',
     '!test/functional/fixtures/regression/gh-5886/test.js',
-    '!test/functional/fixtures/regression/gh-664/test.js',
     '!test/functional/fixtures/regression/hammerhead/gh-2350/test.js',
 ];
 

diff --git a/src/proxyless/request-pipeline/index.ts b/src/proxyless/request-pipeline/index.ts
@@ -238,7 +238,7 @@ export default class ProxylessRequestPipeline extends ProxylessApiBase {
     private async _handleOtherRequests (event: RequestPausedEvent): Promise<void> {
         requestPipelineOtherRequestLogger('%r', event);
 
-        if (isRequest(event) || isRedirectStatusCode(event.responseStatusCode)) {
+        if (!event.responseErrorReason && (isRequest(event) || isRedirectStatusCode(event.responseStatusCode))) {
             this._contextInfo.init(event);
 
             await this.requestHookEventProvider.onRequest(event, this._contextInfo);

diff --git a/test/functional/fixtures/page-error/test.js b/test/functional/fixtures/page-error/test.js
@@ -1,8 +1,7 @@
-const { expect }          = require('chai');
-const { skipInProxyless } = require('../../utils/skip-in');
+const { expect } = require('chai');
 
 describe('Handle page error', function () {
-    skipInProxyless('Should fail if the error is not caught in the test', function () {
+    it('Should fail if the error is not caught in the test', function () {
         return runTests('./testcafe-fixtures/page-error-test.js', 'Do not handle', { shouldFail: true })
             .catch(function (errs) {
                 expect(errs[0]).contains('Failed to load the page at "http://some-unreachable.url/". ' +