Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap doesn't set hoverPseudoClass on an element in Android (close #294) #309

Merged
merged 1 commit into from
Dec 2, 2015

Conversation

churkin
Copy link
Contributor

@churkin churkin commented Dec 2, 2015

\cc @helen-dikareva @AndreyBelym @inikulin

Breaking changes:
methods
hammerhead.eventSandbox.focusBlur.fixHoveredElement hammerhead.eventSandbox.focusBlur.freeHoveredElement
moved to
hammerhead.eventSandbox.hover.fixHoveredElement
hammerhead.eventSandbox.hover.freeHoveredElement

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 234d59b have failed. See details.

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 234d59b have passed. See details.

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

FPR

@helen-dikareva
Copy link
Collaborator

What about binding to 'mouseout' (and 'touchend' in this case) event https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-5a4f875dc63f1cf4193b951060ba8bfdL246?

@helen-dikareva
Copy link
Collaborator

Send events like an array ['mouseover', 'touchstart' ]https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-54889942d84ec0c0d8f4cb8b1bbf8562R81

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

@helen-dikareva for what? I could not think why this was necessary.

@helen-dikareva
Copy link
Collaborator

https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-49464c29215a80f8b83d2a390c38ac95R20
Use var parent = ... without jquery because you often use $parent[0]

@helen-dikareva
Copy link
Collaborator

removeChild instead of jquery remove()

@helen-dikareva
Copy link
Collaborator

This test can be actual for touch devices now (like a previos one) https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-49464c29215a80f8b83d2a390c38ac95R50

@helen-dikareva
Copy link
Collaborator

\r-

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

@helen-dikareva I would leave it. Otherwise, it is necessary to exclude all jquery form the tests.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a3d0822 have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 174dbda have failed. See details.

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

@testcafe-build-bot \retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 174dbda have passed. See details.

@churkin
Copy link
Contributor Author

churkin commented Dec 2, 2015

FPR

@inikulin
Copy link
Contributor

inikulin commented Dec 2, 2015

lgtm. Let's bump version to 3.0

@AndreyBelym
Copy link
Contributor

lgtm

helen-dikareva added a commit that referenced this pull request Dec 2, 2015
Tap doesn't set hoverPseudoClass on an element in Android (close #294)
@helen-dikareva helen-dikareva merged commit 7d4a042 into DevExpress:master Dec 2, 2015
@churkin churkin mentioned this pull request Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants