-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tap doesn't set hoverPseudoClass on an element in Android (close #294) #309
Conversation
@testcafe-build-bot \retest |
FPR |
What about binding to 'mouseout' (and 'touchend' in this case) event https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-5a4f875dc63f1cf4193b951060ba8bfdL246? |
Send events like an array ['mouseover', 'touchstart' ]https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-54889942d84ec0c0d8f4cb8b1bbf8562R81 |
@helen-dikareva for what? I could not think why this was necessary. |
https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-49464c29215a80f8b83d2a390c38ac95R20 |
removeChild instead of jquery remove() |
This test can be actual for touch devices now (like a previos one) https://github.com/DevExpress/testcafe-hammerhead/pull/309/files#diff-49464c29215a80f8b83d2a390c38ac95R50 |
\r- |
@helen-dikareva I would leave it. Otherwise, it is necessary to exclude all jquery form the tests. |
@testcafe-build-bot \retest |
FPR |
lgtm. Let's bump version to 3.0 |
lgtm |
Tap doesn't set hoverPseudoClass on an element in Android (close #294)
\cc @helen-dikareva @AndreyBelym @inikulin
Breaking changes:
methods
hammerhead.eventSandbox.focusBlur.fixHoveredElement
hammerhead.eventSandbox.focusBlur.freeHoveredElement
moved to
hammerhead.eventSandbox.hover.fixHoveredElement
hammerhead.eventSandbox.hover.freeHoveredElement