Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test-server test: incorrect socket hang up processing error in Node v21 #2978

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix test-server test: incorrect socket hang up processing error in Node v21 #2978

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72d1ab5
refactor check for error socket hang up
PavelMor25 Nov 15, 2023
ea727ff
added note
PavelMor25 Nov 15, 2023
0f003c4
typo correction
PavelMor25 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/request-pipeline/destination-request/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,17 @@ export default class DestinationRequest extends EventEmitter implements Destinat
return err.message && SOCKET_HANG_UP_ERR_RE.test(err.message) &&
// NOTE: At this moment, we determinate the socket hand up error by internal stack trace.
// TODO: After what we will change minimal node.js version up to 8 need to rethink this code.
err.stack && (err.stack.includes('createHangUpError') || err.stack.includes('connResetException'));
// NOTE: In Node.js v21.2, the error trace preparation process was modified,
// and the way to invoke the "socket hang up" error was changed
// from the `connResetException` function call to a constructor (https://github.com/nodejs/node/commit/14e3675b13#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43).
// As a result, the connResetException no longer appears in the stack.
err.stack && this._isSocketHangUpErrHasNeededStack(err.stack);
}

_isSocketHangUpErrHasNeededStack (errStack): boolean {
const stacks = ['createHangUpError', 'connResetException', 'socketCloseListener', 'socketOnEnd'];

return stacks.some( stack => errStack.includes(stack));
}

_onTimeout (): void {
Expand Down