fix: add id to websocket transport messages, remove injectables for NA #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Aleksey28
requested changes
Aug 8, 2023
Artem-Babich
force-pushed
the
fix-injectables-na
branch
from
792a8f3
to
2fd35bf
Compare
miherlosev
approved these changes
Aug 14, 2023
Aleksey28
approved these changes
Aug 14, 2023
|
Release v31.5.0 addresses this. |
Artem-Babich
added a commit
to DevExpress/testcafe
that referenced
this pull request
Aug 21, 2023
## Purpose Support NA in TestCafe Studio ## Approach Described here: DevExpress/testcafe-hammerhead#2946 ## References DevExpress/testcafe-hammerhead#2946 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: artem-babich <artem.babich@devexpress.com>
miherlosev
pushed a commit
to miherlosev/testcafe
that referenced
this pull request
Aug 22, 2023
…press#7878) ## Purpose Support NA in TestCafe Studio ## Approach Described here: DevExpress/testcafe-hammerhead#2946 ## References DevExpress/testcafe-hammerhead#2946 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: artem-babich <artem.babich@devexpress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support NA in TestCafe Studio
Approach
Injectables
Do not fill injactables for NA mode. We inject all scripts in the NA Resource Injector.
By removing these injectables we can now inject our custom scripts in NA mode on TestRun level
Transport
Add id field to messages in order to resolve the promises in the correct order. It is required for the TestCafe Studio. It can send multiple messages at the same time and do not await their answer
References
DevExpress/testcafe#7878
Pre-Merge TODO