Skip to content

Commit

Permalink
build(deps-dev): bump express from 4.18.2 to 4.19.2 (#3001)
Browse files Browse the repository at this point in the history
* build(deps-dev): bump express from 4.18.2 to 4.19.2

Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* skip for firefox

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavel <palich_morozov@mail.ru>

Starting from version 124, Firefox has altered its WebSocket behavior. WebSocket no longer throws errors with invalid URLs, which led us to skip tests on Firefox.
  • Loading branch information
dependabot[bot] authored Apr 1, 2024
1 parent 4c39d6a commit 1d8fe9a
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 70 deletions.
69 changes: 9 additions & 60 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"eslint": "^7.13.0",
"eslint-plugin-hammerhead": "^0.4.0",
"eslint-plugin-no-only-tests": "^2.0.1",
"express": "4.18.2",
"express": "4.19.2",
"express-ntlm": "2.1.5",
"gulp": "^4.0.0",
"gulp-clone": "^2.0.1",
Expand Down
22 changes: 13 additions & 9 deletions test/client/fixtures/sandbox/node/classes-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ var processScript = hammerhead.utils.processing.script.processScript;
var browserUtils = hammerhead.utils.browser;
var nativeMethods = hammerhead.nativeMethods;

var isFirefox = browserUtils.isFirefox;

if (window.PerformanceNavigationTiming) {
test('PerformanceNavigationTiming.name', function () {
var storedNativePerformanceEntryNameGetter = nativeMethods.performanceEntryNameGetter;
Expand Down Expand Up @@ -544,17 +546,19 @@ if (window.WebSocket) {
new WebSocket('');
});

throws(function () {
new WebSocket('/path');
});
if (!isFirefox) {
throws(function () {
new WebSocket('/path');
});

throws(function () {
new WebSocket('//example.com');
});
throws(function () {
new WebSocket('//example.com');
});

throws(function () {
new WebSocket('http://example.com');
});
throws(function () {
new WebSocket('http://example.com');
});
}
});
/* eslint-enable no-new */
}
Expand Down

0 comments on commit 1d8fe9a

Please sign in to comment.