TreeList - Column button does not accept ColumnButtonClickEvent as the onClick event type (T1319919)#32404
Open
mpreyskurantov wants to merge 2 commits intoDevExpress:26_1from
Open
TreeList - Column button does not accept ColumnButtonClickEvent as the onClick event type (T1319919)#32404mpreyskurantov wants to merge 2 commits intoDevExpress:26_1from
mpreyskurantov wants to merge 2 commits intoDevExpress:26_1from
Conversation
…lickEvent type in onClick prop
…-angular/src/ui/nested/base/text-editor-button-dxi.ts via single rule, ref DevExpress#25395
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated ColumnButtonClickEvent API surface for TreeList column-button clicks and propagates that type through generated typings and wrappers to match DataGrid’s existing pattern.
Changes:
- Documents
ColumnButtonClickEventin TreeList typings and addsrow/columnmember doc links. - Updates TreeList column button
onClickcallback typing to useColumnButtonClickEventacross core typings and React/Vue/Angular wrappers. - Removes the incorrect
onClickexposure from the generic Angular text-editordxi-buttonnested option base.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Adds documentation descriptors for ColumnButtonClickEvent and its members in the bundled declarations. |
| packages/devextreme/js/ui/tree_list.d.ts | Introduces full doc metadata for ColumnButtonClickEvent and updates dxTreeListColumnButton.onClick param doc reference. |
| packages/devextreme-vue/src/tree-list.ts | Aligns Vue wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-react/src/tree-list.ts | Aligns React wrapper onClick prop types for TreeList column buttons to ColumnButtonClickEvent. |
| packages/devextreme-metadata/make-angular-metadata.ts | Adds a metadata mutation intended to remove ColumnButton.onClick members (risk: can affect generated Angular API). |
| packages/devextreme-angular/src/ui/tree-list/nested/column-button-dxi.ts | Updates Angular TreeList column-button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/tree-list/nested/button-dxi.ts | Updates Angular TreeList button onClick typing to ColumnButtonClickEvent. |
| packages/devextreme-angular/src/ui/nested/button-dxi.ts | Removes onClick from generic dxi-button inputs (text editor button config). |
| packages/devextreme-angular/src/ui/nested/base/text-editor-button-dxi.ts | Removes incorrect onClick accessor and unrelated ColumnButtonClickEvent import from the text-editor button base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for:
Docs: