DateView: Improve types #32110
Open
DateView: Improve types #32110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-farkhutdinov
force-pushed
the
26_1_date_view_types
branch
from
bebdf94 to
af79a51
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves TypeScript types in the DateView component by adding explicit type annotations, removing unnecessary ts-expect-error suppressions, and modernizing code patterns. The changes enhance type safety and code maintainability.
Key changes:
- Added type imports (
Device,DefaultOptionsRule) and created a newRollerConfiginterface to replace implicit typing - Replaced legacy
each()iterator with modernforEach()and converted function expressions to arrow functions for betterthisbinding - Added comprehensive type annotations to method parameters and return types throughout the class
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ruslan Farkhutdinov <fr3ddy4@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.