DataGrid: Fix updating of the focused row index after a row update when the repaintChangesOnly option is enabled (T1292991) #30754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alyar666
force-pushed
the
T1292991_25_2
branch
2 times, most recently
from
c438faa to
f7f9f90
Compare
Alyar666
changed the title
Tucchhaa
reviewed
Sep 2, 2025
| })); | ||
|
|
||
| // T1292991 | ||
| test('Focused row index should be updated after updating a row when repaintChangesOnly is enabled', async (t) => { |
Contributor
There was a problem hiding this comment.
Suggestion: since the fix was quite complex with taking into account previous tickets and refactoring, can we add matrix tests that will cover the issue more widely? I think this will help us to reduce chances of receiving again similar issues from customers.
Like: one loop for repaintChangesOnly: [true, false] and another loop for changeType: ['insert', 'remove', 'update']. And in the test we check that focusedRowKey and focusedRowIndex are correct and that focusedRowChanged, focusedRowChanging events are called.
Contributor
There was a problem hiding this comment.
Also I suggest to rewrite the test to jest, because this test is fully functional
Tucchhaa
reviewed
Sep 2, 2025
added 2 commits
September 3, 2025 18:23
Alyar666
force-pushed
the
T1292991_25_2
branch
from
f7f9f90 to
75468a7
Compare
Tucchhaa
approved these changes
Sep 4, 2025
Alyar666
added a commit
to Alyar666/DevExtreme
that referenced
this pull request
Sep 4, 2025
…en the repaintChangesOnly option is enabled (T1292991) (DevExpress#30754) Co-authored-by: Alyar <>
Alyar666
added a commit
to Alyar666/DevExtreme
that referenced
this pull request
Sep 4, 2025
…en the repaintChangesOnly option is enabled (T1292991) (DevExpress#30754) Co-authored-by: Alyar <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.