Skip to content

fix: v0.3.7 quick wins (9 issues)#49

Merged
ewega merged 1 commit into
mainfrom
fix/v0.3.7-quick-wins
Feb 19, 2026
Merged

fix: v0.3.7 quick wins (9 issues)#49
ewega merged 1 commit into
mainfrom
fix/v0.3.7-quick-wins

Conversation

@ewega

@ewega ewega commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Independent bug fixes and improvements for v0.3.7. No architectural changes — those come in PR2 (scope/project separation).

Changes

Issue Fix File
#31 Validate empty resourceGroup before Azure cleanup cmd/cleanup.go
#32 Remove duplicate PAT scope printing in connection creation cmd/configure_connections.go
#33 Add "Testing connection..." message before test API call cmd/connection_types.go
#34 Increase HTTP client timeout from 30s to 90s internal/devlake/client.go
#36 Remove auto-connection pickup, always show interactive picker cmd/configure_projects.go
#43 Warn when state file URL found but backend is unreachable internal/devlake/discovery.go
#44 Replace duplicate stateFile struct with LoadState() internal/devlake/discovery.go
#47 Fix state dedup to use plugin+connectionID (not plugin alone) cmd/configure_connections.go
#48 Remove duplicate PAT scope printing in configure full cmd/configure_full.go

Testing

Closes #31, #32, #33, #34, #36, #43, #44, #47, #48

- #31: Add validation for empty resourceGroup in Azure cleanup
- #32: Remove duplicate PAT scope printing in configure connection
- #33: Add 'Testing connection...' message before connection test
- #34: Increase HTTP client timeout from 30s to 90s
- #36: Remove auto-connection pickup in configure project (always prompt)
- #43: Discovery warns when state file URL found but backend unreachable
- #44: Replace duplicate stateFile struct with LoadState() from state.go
- #47: Fix state dedup key to use plugin+connectionID (not plugin alone)
- #48: Remove duplicate PAT scope printing in configure full

Closes #31, #32, #33, #34, #36, #43, #44, #47, #48
Copilot AI review requested due to automatic review settings February 19, 2026 20:15
@ewega ewega added this to the v0.3.7 milestone Feb 19, 2026
@ewega ewega merged commit 9a3f722 into main Feb 19, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses 9 independent bug fixes and UX improvements for v0.3.7 without any architectural changes. The changes improve error handling, remove redundant output, fix state file management, and increase timeout for remote DevLake instances.

Changes:

  • Improved error handling with validation for empty Azure resource groups and warnings for unreachable DevLake URLs in state files
  • Enhanced UX by removing duplicate PAT scope printing and adding connection test feedback messages
  • Fixed state file management to properly track multiple connections per plugin using plugin+connectionID as the dedup key
  • Increased HTTP client timeout from 30s to 90s to support remote DevLake instances with higher latency
  • Removed auto-connection pickup behavior to require explicit user selection

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cmd/cleanup.go Adds validation to ensure resourceGroup is not empty before attempting Azure cleanup
cmd/configure_connections.go Removes duplicate PAT scope printing and fixes state dedup to use plugin+connectionID instead of plugin alone
cmd/configure_full.go Removes duplicate PAT scope printing during connection creation
cmd/configure_projects.go Removes auto-connection pickup logic to always show interactive picker
cmd/connection_types.go Adds "Testing connection..." message before connection test API call
internal/devlake/client.go Increases HTTP client timeout from 30s to 90s for remote instance support
internal/devlake/discovery.go Replaces duplicate stateFile struct with LoadState() and adds warning when state file URL is unreachable

Comment thread cmd/connection_types.go
}

if def.SupportsTest {
fmt.Println(" 🔑 Testing connection...")

Copilot AI Feb 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emoji should be 🔌 (plug) not 🔑 (key) for "Testing connection..." to match the established pattern in the codebase. The 🔌 emoji is used for connection testing operations (see configure_connection_test_cmd.go line 140 and configure_connection_update.go line 177), while 🔑 is reserved for authentication/token operations.

Suggested change
fmt.Println(" 🔑 Testing connection...")
fmt.Println(" 🔌 Testing connection...")

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure cleanup fails when state file has empty resourceGroup/region

2 participants