fix: v0.3.7 quick wins (9 issues)#49
Merged
Merged
Conversation
- #31: Add validation for empty resourceGroup in Azure cleanup - #32: Remove duplicate PAT scope printing in configure connection - #33: Add 'Testing connection...' message before connection test - #34: Increase HTTP client timeout from 30s to 90s - #36: Remove auto-connection pickup in configure project (always prompt) - #43: Discovery warns when state file URL found but backend unreachable - #44: Replace duplicate stateFile struct with LoadState() from state.go - #47: Fix state dedup key to use plugin+connectionID (not plugin alone) - #48: Remove duplicate PAT scope printing in configure full Closes #31, #32, #33, #34, #36, #43, #44, #47, #48
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses 9 independent bug fixes and UX improvements for v0.3.7 without any architectural changes. The changes improve error handling, remove redundant output, fix state file management, and increase timeout for remote DevLake instances.
Changes:
- Improved error handling with validation for empty Azure resource groups and warnings for unreachable DevLake URLs in state files
- Enhanced UX by removing duplicate PAT scope printing and adding connection test feedback messages
- Fixed state file management to properly track multiple connections per plugin using plugin+connectionID as the dedup key
- Increased HTTP client timeout from 30s to 90s to support remote DevLake instances with higher latency
- Removed auto-connection pickup behavior to require explicit user selection
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/cleanup.go | Adds validation to ensure resourceGroup is not empty before attempting Azure cleanup |
| cmd/configure_connections.go | Removes duplicate PAT scope printing and fixes state dedup to use plugin+connectionID instead of plugin alone |
| cmd/configure_full.go | Removes duplicate PAT scope printing during connection creation |
| cmd/configure_projects.go | Removes auto-connection pickup logic to always show interactive picker |
| cmd/connection_types.go | Adds "Testing connection..." message before connection test API call |
| internal/devlake/client.go | Increases HTTP client timeout from 30s to 90s for remote instance support |
| internal/devlake/discovery.go | Replaces duplicate stateFile struct with LoadState() and adds warning when state file URL is unreachable |
| } | ||
|
|
||
| if def.SupportsTest { | ||
| fmt.Println(" 🔑 Testing connection...") |
There was a problem hiding this comment.
The emoji should be 🔌 (plug) not 🔑 (key) for "Testing connection..." to match the established pattern in the codebase. The 🔌 emoji is used for connection testing operations (see configure_connection_test_cmd.go line 140 and configure_connection_update.go line 177), while 🔑 is reserved for authentication/token operations.
Suggested change
| fmt.Println(" 🔑 Testing connection...") | |
| fmt.Println(" 🔌 Testing connection...") |
This was referenced Feb 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent bug fixes and improvements for v0.3.7. No architectural changes — those come in PR2 (scope/project separation).
Changes
cmd/cleanup.gocmd/configure_connections.gocmd/connection_types.gointernal/devlake/client.gocmd/configure_projects.gointernal/devlake/discovery.gostateFilestruct withLoadState()internal/devlake/discovery.gocmd/configure_connections.gocmd/configure_full.goTesting
go build— cleango test ./...— only pre-existing failure inTestRunConfigureScopes_PluginFlag(configure_scopes_test.go only tests helpers and mutates globals without cleanup #45, global state mutation). No new failures.Closes #31, #32, #33, #34, #36, #43, #44, #47, #48