Add `configure connection delete` subcommand by Copilot · Pull Request #25 · DevExpGbb/gh-devlake

Copilot · 2026-02-19T17:11:59Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Add configure connection delete command</issue_title>
<issue_description>## Summary
Add a configure connection delete subcommand to remove connections that are broken, test connections, or no longer needed.

Design (Option A: under configure connection)

gh devlake configure connection delete # interactive gh devlake configure connection delete --plugin gh-copilot --id 3 # flag-based

Interactive flow:

List all connections across plugins

User selects one to delete

Confirmation prompt with warning about losing scopes

DELETE /plugins/{plugin}/connections/{id}

Update state file

Changes

Add delete subcommand under configure connection

Interactive: list connections, prompt select, confirm

Flag-based: --plugin + --id required

Call DELETE /plugins/{plugin}/connections/{id}

Remove from state file after successful deletion

Add DeleteConnection method to devlake.Client

Acceptance Criteria

Interactive mode lists connections and prompts for confirmation

Flag mode works with --plugin + --id

State file updated after deletion

Confirmation prompt warns about scope deletion

Graceful error if connection ID doesn't exist
</issue_description>

<agent_instructions>v0.3.4 just shipped — commands are now singular (connection, scope, project), --plugin flag exists, and configure connection list is a subcommand of configureConnectionsCmd. Work off the latest main.

Key implementation points:

Create a new file cmd/configure_connection_delete.go with a delete subcommand under configureConnectionsCmd

Add DeleteConnection(plugin string, connID int) method to internal/devlake/client.go using DELETE /plugins/{plugin}/connections/{id}

Interactive mode: use configure connection list logic to show connections, prompt user to select one, then confirm with a warning about losing scopes

Flag mode: --plugin + --id required

After successful deletion, remove the connection from the state file using existing state helpers

Graceful error if connection ID doesn't exist

Follow terminal output rules in .github/instructions/terminal-output.instructions.md

Update README.md with the new command documentation

Add tests in configure_connection_delete_test.go

Run go build ./... and go test ./... to verify</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Add configure connection delete command #9

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot

Pull request overview

Adds a new gh devlake configure connection delete subcommand to remove DevLake plugin connections (interactive selection or --plugin/--id flags), wiring it through a new DevLake API client delete method and documenting the command.

Changes:

Add Client.DeleteConnection(plugin, id) that calls DELETE /plugins/{plugin}/connections/{id}.
Introduce configure connection delete command with interactive selection + confirmation and state-file update.
Add basic command registration/validation tests and README documentation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
internal/devlake/client.go	Adds `DeleteConnection` API call for deleting connections by plugin + ID.
cmd/configure_connection_delete.go	Implements the new `configure connection delete` subcommand (interactive + flag mode), confirmation flow, and state update.
cmd/configure_connection_delete_test.go	Adds tests for subcommand registration and unknown-plugin validation.
README.md	Documents the new delete command usage and behavior.

Copilot · 2026-02-19T17:32:50Z

+	plugin := connDeletePlugin
+	connID := connDeleteID
+
+	if plugin == "" || connID == 0 {


The interactive fallback currently triggers when either --plugin or --id is missing (if plugin == "" || connID == 0). This means a partially-specified flag invocation (e.g. --id without --plugin) unexpectedly drops into interactive mode instead of failing fast, which contradicts the documented/required “flag mode requires both” behavior. Consider treating it as flag mode when either flag is set (use cmd.Flags().Changed(...)) and return an error unless both values are provided; reserve interactive mode only when neither flag is set.

Suggested change

if plugin == "" || connID == 0 {

pluginFlagSet := cmd.Flags().Changed("plugin")

idFlagSet := cmd.Flags().Changed("id")

if pluginFlagSet || idFlagSet {

// Flag mode: if either flag is set, require both to be provided and valid

if !pluginFlagSet || !idFlagSet || plugin == "" || connID == 0 {

return fmt.Errorf("both --plugin and --id must be provided together")

}

} else {

Fixed in c4307f4. Flag-mode detection now uses cmd.Flags().Changed("plugin") / cmd.Flags().Changed("id") early (before discovery), so partial invocations fail immediately with "both --plugin and --id must be provided together". Interactive mode is only entered when neither flag is set.

Copilot · 2026-02-19T17:32:51Z

+		updated = append(updated, c)
+	}
+	if err := devlake.UpdateConnections(statePath, state, updated); err != nil {
+		fmt.Fprintf(os.Stderr, "⚠️  Could not update state file: %v\n", err)


Per .github/instructions/terminal-output.instructions.md, emoji-prefixed lines should start with a leading blank line (\n) so they read as distinct steps. This warning is emitted without a preceding blank line, so it can jam against the previous output; prepend a newline (or add an extra fmt.Println() before it) to keep spacing consistent.

Suggested change

fmt.Fprintf(os.Stderr, "⚠️ Could not update state file: %v\n", err)

fmt.Fprintf(os.Stderr, "\n⚠️ Could not update state file: %v\n", err)

Fixed in c4307f4 — prepended \n to the stderr warning: fmt.Fprintf(os.Stderr, "\n⚠️ Could not update state file: %v\n", err).

Copilot · 2026-02-19T17:32:51Z

+	body, _ := io.ReadAll(resp.Body)
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusNoContent {
+		return fmt.Errorf("delete connection returned %d: %s", resp.StatusCode, body)
+	}


DeleteConnection returns a generic status/body error for all non-200/204 responses. The UX requirement mentions a graceful error when the connection ID doesn’t exist; consider special-casing 404 to return a clearer “not found” error (including plugin + id), and consider including the HTTP method/path in the generic error (e.g. DELETE /plugins/{plugin}/connections/{id}) to make troubleshooting easier.

Fixed in c4307f4. DeleteConnection now special-cases 404 with "connection not found: plugin=%s id=%d" and includes the full path in the generic error: "DELETE /plugins/%s/connections/%d returned %d: %s".

Copilot · 2026-02-19T17:32:51Z

+	if !strings.Contains(err.Error(), "unknown plugin") {
+		t.Errorf("unexpected error message: %v", err)
+	}
+}


The tests cover subcommand registration and unknown-plugin validation, but don’t exercise the new command’s required flag-mode behavior (e.g. erroring when only one of --plugin / --id is provided, and accepting when both are provided). Adding a test for these cases will help prevent regressions in the interactive-vs-flag resolution logic.

Suggested change

}

}

func TestRunDeleteConnection_FlagsPluginOnly(t *testing.T) {

origPlugin := connDeletePlugin

origID := connDeleteID

t.Cleanup(func() {

connDeletePlugin = origPlugin

connDeleteID = origID

})

connDeletePlugin = ""

connDeleteID = 0

cmd := &cobra.Command{RunE: runDeleteConnection}

cmd.Flags().StringVar(&connDeletePlugin, "plugin", "", "")

cmd.Flags().IntVar(&connDeleteID, "id", 0, "")

_ = cmd.Flags().Set("plugin", "gitlab")

err := runDeleteConnection(cmd, nil)

if err == nil {

t.Fatal("expected error when only --plugin is provided, got nil")

}

}

func TestRunDeleteConnection_FlagsIDOnly(t *testing.T) {

origPlugin := connDeletePlugin

origID := connDeleteID

t.Cleanup(func() {

connDeletePlugin = origPlugin

connDeleteID = origID

})

connDeletePlugin = ""

connDeleteID = 0

cmd := &cobra.Command{RunE: runDeleteConnection}

cmd.Flags().StringVar(&connDeletePlugin, "plugin", "", "")

cmd.Flags().IntVar(&connDeleteID, "id", 0, "")

_ = cmd.Flags().Set("id", "1")

err := runDeleteConnection(cmd, nil)

if err == nil {

t.Fatal("expected error when only --id is provided, got nil")

}

}

Added in c4307f4: TestRunDeleteConnection_PluginOnlyNoID and TestRunDeleteConnection_IDOnlyNoPlugin both verify that partial flag invocations return "both --plugin and --id must be provided together".

ewega · 2026-02-19T17:58:57Z

@copilot apply changes based on the comments in this thread

…tests Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Initial plan

0016556

Copilot AI assigned Copilot and ewega Feb 19, 2026

Copilot started work on behalf of ewega February 19, 2026 17:12 View session

Add configure connection delete command

a79eb43

Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add configure connection delete command~~ Add configure connection delete subcommand Feb 19, 2026

Copilot AI requested a review from ewega February 19, 2026 17:15

Copilot finished work on behalf of ewega February 19, 2026 17:15

ewega requested a review from Copilot February 19, 2026 17:27

Copilot started reviewing on behalf of ewega February 19, 2026 17:27 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Copilot started work on behalf of ewega February 19, 2026 17:59 View session

Address review comments: flag-mode detection, 404 handling, spacing, …

c4307f4

…tests Co-authored-by: ewega <26189114+ewega@users.noreply.github.com>

Copilot finished work on behalf of ewega February 19, 2026 18:02

ewega marked this pull request as ready for review February 19, 2026 18:04

ewega merged commit c901269 into main Feb 19, 2026

ewega deleted the copilot/add-configure-connection-delete branch March 2, 2026 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `configure connection delete` subcommand#25

Add `configure connection delete` subcommand#25
ewega merged 3 commits into
mainfrom
copilot/add-configure-connection-delete

Copilot AI commented Feb 19, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-	if plugin == "" || connID == 0 {
+	pluginFlagSet := cmd.Flags().Changed("plugin")
+	idFlagSet := cmd.Flags().Changed("id")
+	if pluginFlagSet || idFlagSet {
+		// Flag mode: if either flag is set, require both to be provided and valid
+		if !pluginFlagSet || !idFlagSet || plugin == "" || connID == 0 {
+			return fmt.Errorf("both --plugin and --id must be provided together")
+		}
+	} else {

	fmt.Fprintf(os.Stderr, "⚠️ Could not update state file: %v\n", err)
	fmt.Fprintf(os.Stderr, "\n⚠️ Could not update state file: %v\n", err)

-}
+}
+func TestRunDeleteConnection_FlagsPluginOnly(t *testing.T) {
+	origPlugin := connDeletePlugin
+	origID := connDeleteID
+	t.Cleanup(func() {
+		connDeletePlugin = origPlugin
+		connDeleteID = origID
+	})
+	connDeletePlugin = ""
+	connDeleteID = 0
+	cmd := &cobra.Command{RunE: runDeleteConnection}
+	cmd.Flags().StringVar(&connDeletePlugin, "plugin", "", "")
+	cmd.Flags().IntVar(&connDeleteID, "id", 0, "")
+	_ = cmd.Flags().Set("plugin", "gitlab")
+	err := runDeleteConnection(cmd, nil)
+	if err == nil {
+		t.Fatal("expected error when only --plugin is provided, got nil")
+	}
+}
+func TestRunDeleteConnection_FlagsIDOnly(t *testing.T) {
+	origPlugin := connDeletePlugin
+	origID := connDeleteID
+	t.Cleanup(func() {
+		connDeletePlugin = origPlugin
+		connDeleteID = origID
+	})
+	connDeletePlugin = ""
+	connDeleteID = 0
+	cmd := &cobra.Command{RunE: runDeleteConnection}
+	cmd.Flags().StringVar(&connDeletePlugin, "plugin", "", "")
+	cmd.Flags().IntVar(&connDeleteID, "id", 0, "")
+	_ = cmd.Flags().Set("id", "1")
+	err := runDeleteConnection(cmd, nil)
+	if err == nil {
+		t.Fatal("expected error when only --id is provided, got nil")
+	}
+}

Uh oh!

Conversation

Copilot AI commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design (Option A: under configure connection)

Changes

Acceptance Criteria

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

ewega commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 19, 2026 •

edited

Loading