feat: calculate virtual elements for CDS Views #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves Issue #12 |
stockbal
requested changes
Mar 22, 2021
| CATCH cx_sy_create_object_error | ||
| cx_sy_ref_is_initial | ||
| cx_sy_dyn_call_error | ||
| cx_sadl_exit. |
There was a problem hiding this comment.
the exception cx_sadl_exit does not exist in v7.50 so I gues we have to use cx_root in this case to also catch any exception that happen in the calculate call
Comment on lines
614
to
640
| LOOP AT lt_virtual_elems ASSIGNING FIELD-SYMBOL(<ls_virtual_elem>). | ||
|
|
||
| TRY. | ||
| CREATE OBJECT lo_calculated_by TYPE (<ls_virtual_elem>-value+5). | ||
|
|
||
| create_virtual_elem_table_type( | ||
| EXPORTING iv_virtual_elem = <ls_virtual_elem>-fieldname | ||
| IMPORTING eo_table_type = DATA(lo_table_type) ). | ||
|
|
||
| CREATE DATA lr_t_calc_data TYPE HANDLE lo_table_type. | ||
| ASSIGN lr_t_calc_data->* TO <lt_calculated_data>. | ||
|
|
||
| CALL METHOD lo_calculated_by->('IF_SADL_EXIT_CALC_ELEMENT_READ~CALCULATE') | ||
| EXPORTING | ||
| it_original_data = <lt_selected_data> | ||
| it_requested_calc_elements = VALUE if_sadl_exit_calc_element_read=>tt_elements( ( CONV #( <ls_virtual_elem>-fieldname ) ) ) | ||
| CHANGING | ||
| ct_calculated_data = <lt_calculated_data>. | ||
|
|
||
| CATCH cx_sy_create_object_error | ||
| cx_sy_ref_is_initial | ||
| cx_sy_dyn_call_error | ||
| cx_sadl_exit. | ||
| RETURN. | ||
| ENDTRY. | ||
|
|
||
| ENDLOOP. |
There was a problem hiding this comment.
I am not quite sure how the SADL engine is handling this, but wouldn't it be better to group the calculcation by exit-class?
Example:
...
@ObjectModel.virtualElementCalculatedBy: 'ABAP:CL_EXIT'
cast( '' as ztype ) as VirtualField1,
@ObjectModel.virtualElementCalculatedBy: 'ABAP:CL_EXIT'
cast( '' as ztype2 ) as VirtualField2,
@ObjectModel.virtualElementCalculatedBy: 'ABAP:CL_EXIT2'
cast( '' as ztype3 ) as VirtualField3,
...So in this example there would be one call to CL_EXIT where the fields VirtualField1 and VirtualField2 are filled and one call to CL_EXIT2 where the field VirtualField3 is filled
Comment on lines
623
to
624
| CREATE DATA lr_t_calc_data TYPE HANDLE lo_table_type. | ||
| ASSIGN lr_t_calc_data->* TO <lt_calculated_data>. |
There was a problem hiding this comment.
Wouldn't this automatically override the calculated data from the previous iteration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.