feat: redact SDKKey in log output

[antoinedeschenes]

The SDK key is currently output to logs when sdk-proxy starts. This change hides the proxy instance config log by default and adds a -show-config startup flag to enable it when required.

[JamieSinn]

We generally approached this concept with the fact customers would react it upstream in their logs via datadog, splunk, etc. Having it print is mostly a debug confirmation that you're looking at the correct instance of the token. If it's an issue, it might be easier to just make a startup flag that prints the object/struct including the sdk key, and if it's not specified it doesn't.

The logs from the service also have other components that are higher sensitivity too, but that's environment dependant.

[JamieSinn]

The flag would wrap this debug line here

https://github.com/DevCycleHQ/sdk-proxy/blob/main/cmd/main.go#L52

[antoinedeschenes]

The flag would wrap this debug line here

https://github.com/DevCycleHQ/sdk-proxy/blob/main/cmd/main.go#L52

Updated with the startup flag suggestion. We don't have a convenient way to sanitize logs within our log stack currently, but we did roll a custom image wrapping the process within vector to redact the log lines in the sidecar. This works fine but we'd rather rely on the provided image in the long term

[antoinedeschenes]

@JamieSinn thanks for merging! Is a new release planned soon?

[JamieSinn]

i can push a patch release through - but we don't have plans otherwise for a larger scale release

[JamieSinn]

https://github.com/DevCycleHQ/sdk-proxy/releases/tag/v2.5.3

[antoinedeschenes]

Awesome, thanks for this 🙇‍♂️