Skip to content

Conversation

@chris-hoefgen
Copy link
Contributor

@chris-hoefgen chris-hoefgen commented May 9, 2023

  • switched the SDK from getting all variables to using new variableForUser function in the WASM
  • update logic to match what is done in Go/.Net/Ruby
  • updated to latest WASM file
  • Added data fixture files to load via class path instead of hardcoded variable
  • Added large fixture file used for testing other SDKs like Go and DotNet
  • Changed the unit tests to use an actual config web server to properly test initialization and variable evaluation

@chris-hoefgen chris-hoefgen marked this pull request as draft May 9, 2023 21:17
@chris-hoefgen chris-hoefgen changed the title DVC-6643 Integrate WASM Optimizations DVC-6643 - Update variable() to use new WASM variableForUser function May 11, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a bit controversial but it got the job done. The more correct way is to build out a decent mock framework to serve the config data instead of using a real web server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably replace this in a future PR by creating a way to inject an alternative DVCAPI instance into the constructor workflow for the DVCClient

@chris-hoefgen chris-hoefgen force-pushed the DVC-6643-wasm-optimizations branch from 2d3b124 to 944f644 Compare May 11, 2023 22:23
@chris-hoefgen chris-hoefgen marked this pull request as ready for review May 12, 2023 16:43
@chris-hoefgen chris-hoefgen force-pushed the DVC-6643-wasm-optimizations branch from 0e98209 to 580f365 Compare May 12, 2023 17:13
@chris-hoefgen chris-hoefgen merged commit 67d56bf into main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants