-
Notifications
You must be signed in to change notification settings - Fork 0
DVC-6643 - Update variable() to use new WASM variableForUser function #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a bit controversial but it got the job done. The more correct way is to build out a decent mock framework to serve the config data instead of using a real web server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably replace this in a future PR by creating a way to inject an alternative DVCAPI instance into the constructor workflow for the DVCClient
2d3b124 to
944f644
Compare
src/main/java/com/devcycle/sdk/server/local/api/DVCLocalClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/devcycle/sdk/server/local/api/DVCLocalClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/devcycle/sdk/server/local/bucketing/LocalBucketing.java
Outdated
Show resolved
Hide resolved
0e98209 to
580f365
Compare
Uh oh!
There was an error while loading. Please reload this page.