fix: serialize userConfig access to prevent objc_retain crash #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

jonathannorris wants to merge 1 commit into main from fix-userconfig-thread-safety

Member

jonathannorris commented Aug 27, 2025 •

edited

Loading

Root cause: Data race on DVCConfig.userConfig between main-thread writes and background reads, causing intermittent objc_retain crashes.
Solution:
- Add concurrent queue with barrier writes and synchronized reads for DVCConfig.userConfig.
- Post NEW_USER_CONFIG notifications on the main thread.
- Include test JSON fixtures in SwiftPM test target and load via Bundle.module.

Changes

DevCycle/Models/DVCConfig.swift: thread-safe accessor for userConfig; main-thread notifications.
Package.swift: process DevCycleTests/Models/test_config.json and ..._eval_reason.json as resources.
DevCycleTests/Utils/GetTestConfig.swift: use Bundle.module for SPM.

Testing

Ran swift test: 155/155 tests passing.

Impact

No public API changes.
Safer concurrent access; eliminates observed crashes in allVariables()/getVariable().


          fix: serialize userConfig access and post notifications on main; add …

768258f

…SPM test resources

jonathannorris requested a review from jsalaber

August 27, 2025 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet