fix: support user_id / userId in OF Context #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suthar26
approved these changes
Jul 18, 2025
kaushalkapasi
approved these changes
Jul 18, 2025
JamieSinn
reviewed
Jul 18, 2025
...d-client-sdk/src/test/java/com/devcycle/sdk/android/openfeature/DevCycleContextMapperTest.kt
Show resolved
Hide resolved
suthar26
requested changes
Jul 18, 2025
android-client-sdk/src/main/java/com/devcycle/sdk/android/openfeature/DevCycleContextMapper.kt
Outdated
Show resolved
Hide resolved
JamieSinn
reviewed
Jul 22, 2025
| // Use direct asMap method call instead of reflection | ||
| context.asMap().forEach { (key, value) -> | ||
| when (key) { | ||
| "userId", "user_id" -> { |
Member
Author
There was a problem hiding this comment.
targetingKey isn't included in the context.asMap()
Member
There was a problem hiding this comment.
that's interesting - what if you set it as a property on the context instead? does that still hold true?
Member
Author
There was a problem hiding this comment.
basically the targetingKey is stored as a different var: https://github.com/open-feature/kotlin-sdk/blob/d8b58b48ad1a89ab31e1f1c2d553e6c7c516f7a8/android/src/main/java/dev/openfeature/sdk/ImmutableContext.kt#L6
Member
There was a problem hiding this comment.
yeah - found that code; it's odd that it wasn't the same as other sdks
suthar26
reviewed
Jul 22, 2025
android-client-sdk/src/main/java/com/devcycle/sdk/android/openfeature/DevCycleContextMapper.kt
Show resolved
Hide resolved
JamieSinn
approved these changes
Jul 23, 2025
suthar26
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances
DevCycleContextMapperto support additional user ID sources from OpenFeature evaluation context, allowinguserIdanduser_idcontext attributes to be mapped to the DevCycle user ID field. This matches behaviour of our other SDKs and OF Providers.Changes
Modified
DevCycleContextMapper.ktto check for user ID in the following priority order:context.getTargetingKey()(highest priority - existing behavior)context.getValue("userId")(new)context.getValue("user_id")(new)Added logic to handle these attributes in custom data mapping:
Added comprehensive test coverage for the new functionality