Winner list is now check if there is any in there. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If none, a message is send that there are no winners. Added the same check before the currency change just to be sure.
AridTag
suggested changes
Apr 4, 2018
| if (winnersList.Count() > 1) | ||
| chatClient.SendMessage($"The winners are {winners}!"); | ||
| else | ||
| chatClient.SendMessage($"The winners is {winners}!"); |
There was a problem hiding this comment.
The message for the singular winner should read The winner is {winners}!
There was a problem hiding this comment.
Good catch, I'll fix it now 👍
benrick
approved these changes
Apr 4, 2018
|
Well done, both of you. We'll merge this in tomorrow at the start of the stream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If none, a message is send that there are no winners.
Added the same check before the currency change just to be sure.
Changes for #60