Skip to content

#9 GitHub actions build pipeline - attempt 1 of ?? (yay for YAML) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2020

Conversation

SimonGeering
Copy link
Member

@SimonGeering SimonGeering commented Aug 9, 2020

Step 1 of #9 providing an initial CI/CD build pipeline;

This is just the simple PR workflow that will compile the solution and run all the tests in the test project.

Since we may want to filter tests by category later, so ill add annotations to the existing unit tests for that, as it will also give me something to PR into my own main branch to test the triggers.

This also fixes #33 with the resolution of a null reference bug.

Just does a build and runs tests whenever we get a PR into dev or main, nothing fancy.
…w for future filtering and to give something to trigger a test run of the PR build pipeline.
WPF build dependencies require a Windows OS image for the build.
…and causing null reference exception, un-blocks DevChatter#9, See also DevChatter#34.
@SimonGeering
Copy link
Member Author

@benrick, after this PR is merged to main would you also be able to get the dev branch cut from main please?
Not only would that allow the other trigger for this pipeline to be tested, but it would also be best if I were to make future PR branches off of dev as a step towards implementing the final structure in #23

Copy link
Member

@benrick benrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple set of build steps.

jobs:
build:

runs-on: windows-latest #Can't use anything else as WPF build has a windows dependency - waiting on .NET MAUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'm hopeful that MAUI will have all the cool stuff we want.

@benrick benrick merged commit ce15361 into DevChatter:main Aug 9, 2020
@SimonGeering
Copy link
Member Author

Obviously you will need to set-up the branch protection rules once it's in on your side.
If I recall correctly the build has to run once before you can enforce it as a constraint on a PR, but you should still be able to enable Require status checks to pass before merging

@SimonGeering SimonGeering deleted the #9-BuildPipeline-main branch August 9, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failing in main branch - need to get clean baseline.
2 participants