Merge pull request bitcoinjs#113 from bitcoinjs/fixTypes

Fix mnemonicToSeed password arg to optional
Deutsch4534 · Apr 11, 2019 · 6878403 · 6878403
2 parents d5fb1ed + 743c7c0
commit 6878403
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bip39",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "Bitcoin BIP39: Mnemonic code for generating deterministic keys",
   "main": "src/index.js",
   "types": "./types/index.d.ts",

diff --git a/ts_src/index.ts b/ts_src/index.ts
@@ -39,7 +39,10 @@ function salt(password?: string): string {
   return 'mnemonic' + (password || '');
 }
 
-export function mnemonicToSeedSync(mnemonic: string, password: string): Buffer {
+export function mnemonicToSeedSync(
+  mnemonic: string,
+  password?: string,
+): Buffer {
   const mnemonicBuffer = Buffer.from(
     (mnemonic || '').normalize('NFKD'),
     'utf8',
@@ -54,7 +57,7 @@ export function mnemonicToSeedSync(mnemonic: string, password: string): Buffer {
 
 export function mnemonicToSeed(
   mnemonic: string,
-  password: string,
+  password?: string,
 ): Promise<Buffer> {
   return new Promise(
     (resolve, reject): void => {

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -1,6 +1,6 @@
 /// <reference types="node" />
-export declare function mnemonicToSeedSync(mnemonic: string, password: string): Buffer;
-export declare function mnemonicToSeed(mnemonic: string, password: string): Promise<Buffer>;
+export declare function mnemonicToSeedSync(mnemonic: string, password?: string): Buffer;
+export declare function mnemonicToSeed(mnemonic: string, password?: string): Promise<Buffer>;
 export declare function mnemonicToEntropy(mnemonic: string, wordlist?: string[]): string;
 export declare function entropyToMnemonic(entropy: Buffer | string, wordlist?: string[]): string;
 export declare function generateMnemonic(strength?: number, rng?: (size: number) => Buffer, wordlist?: string[]): string;