Skip to content

fixup: make binary cache nuclear option more general#524

Merged
cole-h merged 1 commit into
mainfrom
more-general-binary-cache-cache-clearing
Jun 26, 2026
Merged

fixup: make binary cache nuclear option more general#524
cole-h merged 1 commit into
mainfrom
more-general-binary-cache-cache-clearing

Conversation

@cole-h

@cole-h cole-h commented Jun 26, 2026

Copy link
Copy Markdown
Member

Recently, we added a binary-cache-detsys-v1.sqlite file, and these instructions would not remove that.

Motivation

Context

Summary by CodeRabbit

  • Documentation
    • Clarified the cache cleanup command in the narinfo-cache-negative-ttl setting notes.
    • Updated the example to remove all matching binary cache SQLite files, not just a narrower versioned subset.

Recently, we added a `binary-cache-detsys-v1.sqlite` file, and these
instructions would not remove that.
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5044c32d-dbb0-40b2-93ec-f908d0159020

📥 Commits

Reviewing files that changed from the base of the PR and between 923cd70 and 3de4ffc.

📒 Files selected for processing (1)
  • src/libstore/include/nix/store/globals.hh

📝 Walkthrough

Walkthrough

The narinfo-cache-negative-ttl help text updates its example cleanup command to remove binary-cache-*.sqlite* files instead of binary-cache-v*.sqlite*. No configuration defaults or exported interfaces changed.

Changes

Store help text update

Layer / File(s) Summary
Example cache cleanup glob
src/libstore/include/nix/store/globals.hh
The narinfo-cache-negative-ttl example command changes the removed filename glob to binary-cache-*.sqlite*.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped through the docs with a twitchy nose,
A wider glob for the cleanup shows.
One tiny tweak in the cache-file light,
Keeps the stale bits out of sight.
Hoppy tidy, neat and sweet!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the change to broaden the binary cache cleanup instructions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch more-general-binary-cache-cache-clearing

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request June 26, 2026 15:29 Inactive
@cole-h cole-h enabled auto-merge June 26, 2026 15:31
@cole-h cole-h added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit 3888c31 Jun 26, 2026
33 checks passed
@cole-h cole-h deleted the more-general-binary-cache-cache-clearing branch June 26, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants