LocalStore::doAddToStore(): Check NAR size before NAR hash

[edolstra]

Motivation

Same as #510, to get around our CI being broken for PRs from external contributors.

If the file size is wrong, the hash is almost certainly wrong. Checking the size first provides useful information that is not shown otherwise.

Size mismatch indicates issues like truncated files, whereas hash mismatch for the matching file size suggests data corruption. Reporting the correct condition helps troubleshoot the issue.

Context

---

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

---

Closes #510

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e83aa462-2be0-496f-96eb-9dcbdec29e2e

📥 Commits

Reviewing files that changed from the base of the PR and between 21ed367 and 4c933bf.

📒 Files selected for processing (2)

• src/libstore/local-store.cc
• tests/functional/binary-cache.sh

 _______________________________________________________________________
< Simplicity does not precede complexity, but follows it. - Alan Perlis >
 -----------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch check-size-before-hash-2

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Deployed on https://6a32c052c40f7e00fd9e0040--determinate-nix.netlify.app

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}