Skip to content

Lint #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2016
Merged

Lint #274

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ _site
.DS_Store
Gemfile.lock
.sass-cache
tmp/
243 changes: 243 additions & 0 deletions .scss-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,243 @@
scss_files: "_sass/**/*.scss"

linters:
BangFormat:
enabled: false
space_before_bang: true
space_after_bang: false

BemDepth:
enabled: false
max_elements: 1

BorderZero:
enabled: false
convention: zero # or `none`

ChainedClasses:
enabled: false

ColorKeyword:
enabled: false

ColorVariable:
enabled: false

Comment:
enabled: false
style: silent

DebugStatement:
enabled: false

DeclarationOrder:
enabled: false

DisableLinterReason:
enabled: false

DuplicateProperty:
enabled: false

ElsePlacement:
enabled: false
style: same_line # or 'new_line'

EmptyLineBetweenBlocks:
enabled: false
ignore_single_line_blocks: true

EmptyRule:
enabled: false

ExtendDirective:
enabled: false

FinalNewline:
enabled: false
present: true

HexLength:
enabled: false
style: short # or 'long'

HexNotation:
enabled: false
style: lowercase # or 'uppercase'

HexValidation:
enabled: false

IdSelector:
enabled: false

ImportantRule:
enabled: false

ImportPath:
enabled: false
leading_underscore: false
filename_extension: false

Indentation:
enabled: false
allow_non_nested_indentation: false
character: space # or 'tab'
width: 2

LeadingZero:
enabled: false
style: exclude_zero # or 'include_zero'

MergeableSelector:
enabled: false
force_nesting: true

NameFormat:
enabled: false
allow_leading_underscore: true
convention: hyphenated_lowercase # or 'camel_case', or 'snake_case', or a regex pattern

NestingDepth:
enabled: false
max_depth: 3
ignore_parent_selectors: false

PlaceholderInExtend:
enabled: false

PrivateNamingConvention:
enabled: false
prefix: _

PropertyCount:
enabled: false
include_nested: false
max_properties: 10

PropertySortOrder:
enabled: false
ignore_unspecified: false
min_properties: 2
separate_groups: false

PropertySpelling:
enabled: false
extra_properties: []
disabled_properties: []

PropertyUnits:
enabled: false
global: [
'ch', 'em', 'ex', 'rem', # Font-relative lengths
'cm', 'in', 'mm', 'pc', 'pt', 'px', 'q', # Absolute lengths
'vh', 'vw', 'vmin', 'vmax', # Viewport-percentage lengths
'deg', 'grad', 'rad', 'turn', # Angle
'ms', 's', # Duration
'Hz', 'kHz', # Frequency
'dpi', 'dpcm', 'dppx', # Resolution
'%'] # Other
properties: {}

PseudoElement:
enabled: false

QualifyingElement:
enabled: false
allow_element_with_attribute: false
allow_element_with_class: false
allow_element_with_id: false

SelectorDepth:
enabled: false
max_depth: 3

SelectorFormat:
enabled: false
convention: hyphenated_lowercase # or 'strict_BEM', or 'hyphenated_BEM', or 'snake_case', or 'camel_case', or a regex pattern

Shorthand:
enabled: false
allowed_shorthands: [1, 2, 3]

SingleLinePerProperty:
enabled: false
allow_single_line_rule_sets: true

SingleLinePerSelector:
enabled: false

SpaceAfterComma:
enabled: false
style: one_space # or 'no_space', or 'at_least_one_space'

SpaceAfterPropertyColon:
enabled: false
style: one_space # or 'no_space', or 'at_least_one_space', or 'aligned'

SpaceAfterPropertyName:
enabled: false

SpaceAfterVariableColon:
enabled: false
style: one_space # or 'no_space', 'at_least_one_space' or 'one_space_or_newline'

SpaceAfterVariableName:
enabled: false

SpaceAroundOperator:
enabled: false
style: one_space # or 'at_least_one_space', or 'no_space'

SpaceBeforeBrace:
enabled: false
style: space # or 'new_line'
allow_single_line_padding: false

SpaceBetweenParens:
enabled: false
spaces: 0

StringQuotes:
enabled: false
style: single_quotes # or double_quotes

TrailingSemicolon:
enabled: false

TrailingWhitespace:
enabled: false

TrailingZero:
enabled: false

TransitionAll:
enabled: false

UnnecessaryMantissa:
enabled: false

UnnecessaryParentReference:
enabled: false

UrlFormat:
enabled: false

UrlQuotes:
enabled: false

VariableForProperty:
enabled: false
properties: []

VendorPrefix:
enabled: false
identifier_list: base
additional_identifiers: []
excluded_identifiers: []

ZeroUnit:
enabled: false

Compass::*:
enabled: false
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
language: ruby
rvm:
- 2.1
script: bundle exec rake test
script:
- bundle exec rake test
- bundle exec rake scss_lint
sudo: false
env:
global:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Thanks for wanting to contribute to [Open Design](http://opendesign.foundation).

## How to Contact Us

The fastest way to get ahold of us is to ping us on twitter [@designopen](http://twitter.com/designopen) [@garthdb](http://twitter.com/garthdb) [@una](http://twitter.com/una) [@terracomma](http://twitter.com/terracomma). If you'd prefer, you could jump into our Slack team; [join here](https://osd-slackin.herokuapp.com/). If you want to talk about an issue or propose a feature, start a [GitHub issue](https://github.com/DesignOpen/designopen.github.io/issues). Finally, if you like email, you can contact Garth at garthdb@gmail.com, he's probably looking for a distraction from something he should be doing.
The fastest way to get ahold of us is to ping us on twitter [@designopen](http://twitter.com/designopen) [@garthdb](http://twitter.com/garthdb) [@una](http://twitter.com/una) [@terracomma](http://twitter.com/moodycomputer). If you'd prefer, you could jump into our Slack team; [join here](https://osd-slackin.herokuapp.com/). If you want to talk about an issue or propose a feature, start a [GitHub issue](https://github.com/DesignOpen/designopen.github.io/issues). Finally, if you like email, you can contact Garth at garthdb@gmail.com, he's probably looking for a distraction from something he should be doing.

## How to Contribute

Expand Down
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ gem 'github-pages'
group :test do
gem 'rake'
gem 'html-proofer'
gem 'scss_lint'
end
28 changes: 26 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ require 'rake'
require 'yaml'
require 'fileutils'
require 'rbconfig'
require 'html/proofer'
require 'html-proofer'
require 'scss_lint/rake_task'

# == Configuration =============================================================

Expand Down Expand Up @@ -201,5 +202,28 @@ end
desc "build and test website"
task :test do
sh "bundle exec jekyll build"
HTML::Proofer.new("./_site", {:href_ignore=> ['http://localhost:4000','http://linkedin.com/in/sachabest','http://www.linkedin.com/pub/david-yuxuan-wei/95/488/77/','http://www.linkedin.com/pub/elaine-hwang/9b/830/739','https://www.linkedin.com/in/ngovkevin'], :typhoeus => { :followlocation => true, :ssl_verifypeer => false, :headers => { 'User-Agent' => 'html-proofer' } }}).run
HTMLProofer.check_directory("./_site-test", {
:empty_alt_ignore => true,
:url_ignore => [
'http://localhost:4000',
'http://linkedin.com/in/sachabest',
'http://www.linkedin.com/pub/david-yuxuan-wei/95/488/77/',
'http://www.linkedin.com/pub/elaine-hwang/9b/830/739',
'https://www.linkedin.com/in/ngovkevin'
],
:cache => {
:timeframe => '1d'
},
:typhoeus => {
:followlocation => true,
:ssl_verifypeer => false,
:headers => { 'User-Agent' => 'html-proofer' }
}
}).run
end


# rake lint
desc "Lint SCSS"
SCSSLint::RakeTask.new do |t|
end
4 changes: 2 additions & 2 deletions articles/_posts/2014-10-24-facebook-open-academy.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Open Design is excited to announce that we have been invited to participate in [

<img src="/img/foa_1.jpg" width="100%" height="auto" alt="picture of students working"/>

I'm pleased to introduce [David Wei](http://www.linkedin.com/pub/david-yuxuan-wei/95/488/77/), [Elaine Hwang](http://www.linkedin.com/pub/elaine-hwang/9b/830/739), and [Kevin Ngo](https://www.linkedin.com/in/ngovkevin) from <abbr title="University of California San Diego">UCSD</abbr>, as well as [Becca Hallac](http://rebeccahallac.com) and [Sacha Best](http://linkedin.com/in/sachabest) from <abbr title="University of Pennsylvania">UPENN</abbr> as our newest contributors. They have decided to tackle the [Open Design job board](https://github.com/DesignOpen/board). [Chris Moody](http://twitter.com/terracomma) and I had the pleasure of participating in an initial orientation and project sprint with them in person at Facebook's headquarters earlier this month, and they are fantastic.
I'm pleased to introduce [David Wei](http://www.linkedin.com/pub/david-yuxuan-wei/95/488/77/), [Elaine Hwang](http://www.linkedin.com/pub/elaine-hwang/9b/830/739), and [Kevin Ngo](https://www.linkedin.com/in/ngovkevin) from <abbr title="University of California San Diego">UCSD</abbr>, as well as [Becca Hallac](http://rebeccahallac.com) and [Sacha Best](http://linkedin.com/in/sachabest) from <abbr title="University of Pennsylvania">UPENN</abbr> as our newest contributors. They have decided to tackle the [Open Design job board](https://github.com/DesignOpen/board). [Chris Moody](http://twitter.com/moodycomputer) and I had the pleasure of participating in an initial orientation and project sprint with them in person at Facebook's headquarters earlier this month, and they are fantastic.

<h2>2014 Group</h2>
<div class="guys">
Expand Down Expand Up @@ -46,4 +46,4 @@ I'm pleased to introduce [David Wei](http://www.linkedin.com/pub/david-yuxuan-we
<img src="/img/foa_2.jpg" width="100%" height="auto" alt="picture of students working"/>
<h2>About Facebook Open Academy</h2>
<p>Open source is a huge part of Facebook engineering. We also believe that contributing to open source projects is one of the best ways a student can prepare for a job in the industry. Open Academy is a program designed to provide a practical, applied software engineering experience as part of a university student’s CS education.</p>
<p>Source: <a href="https://www.facebook.com/notes/facebook-engineering/facebook-open-academy-bringing-open-source-to-cs-curricula/10151806121378920">Facebook&trade;</a></p>
<p>Source: <a href="https://www.facebook.com/OpenAcademyProgram/">Facebook</a></p>
41 changes: 0 additions & 41 deletions articles/_posts/2015-04-28-join-us-at-fowd.md

This file was deleted.

2 changes: 1 addition & 1 deletion resources/_posts/2013-09-25-sparkbox-redesign.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ category: redesigns
contributor: brad_frost
posted_date: 2012-11-26
---
[Sparkbox](http://seesparkbox.com/) is openly redesign their own site, [source on GitHub](https://github.com/sparkbox/sparkbox-website).
[Sparkbox](http://seesparkbox.com/) is openly redesign their own site, [source on GitHub](https://github.com/sparkbox/seesparkbox.com-issuetracker).
10 changes: 0 additions & 10 deletions resources/_posts/2013-10-09-garthdb-on-the-east-wing.md

This file was deleted.