SCSS Refactoring and Linting

[thexavismith]

I was looking through the stylesheets, and I think there might be some refactoring to do. Eliminating CSS using ID's and maybe use some linting? We could use something like CodeClimate or having a pre-commit hook to lint.

[GarthDB]

Sounds awesome. We already have Travis and we could lint there as well.

[GarthDB]

Anything you want to jump on? Or just recommending we do it?

[thexavismith]

I figured I could tackle the refactoring first. And create a smaller pull request. If you want, I can simplify the description and title of the issue for just that.

[GarthDB]

@ttimsmith that sounds great - so I setup scss-lint with travis-ci on the scss-lint branch

It has a config file (/.scss-lint.yml) but I just turned off all the linters, so that tests pass. I think we could turn on each linter one at a time and then fix the failing lints. What do you think @ttimsmith?

[GarthDB]

@ttimsmith we can chat about it here in the issue or you could jump on slack http://slack.opendesign.foundation/

[thexavismith]

Sure! I put in my email twice, but no invite.

[AStoker]

Popping in here. What are you guys using for compiling your code (if at all)? You can easily build in your scss compiling/linting into that process with something like Gulp.

[GarthDB]

@AStoker we are using Jekyll, it has built in support for SCSS. The real benefit is that it compiles on the server (gh-pages) so people can contribute a new article or new code and we don't have to build it locally before publishing.

[GarthDB]

As far as locally checking it, the rake task makes it easy and scss-lint has pretty good editor support. I'm using atom with a scss lint plugin and it will lint the project based on the config file as I go.

[AStoker]

Gotcha, gonna look into that, thanks.

[GarthDB]

@AStoker feel free to poke holes in the build process.