-
-
Notifications
You must be signed in to change notification settings - Fork 41
Mumbai Indians Website #80
Conversation
|
✔️ Deploy Preview for projects-showcase ready! 🔨 Explore the source changes: c33aebc 🔍 Inspect the deploy log: https://app.netlify.com/sites/projects-showcase/deploys/617bcb8ed401d300087f3040 😎 Browse the preview: https://deploy-preview-80--projects-showcase.netlify.app |
|
@shingtesuyash use proper folder structure and add a deployedLink.txt and a thumbnail. Follow CONTIBUTING.md for details |
DevrajDC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @shingtesuyash , check your folder structure and also add a deployedLink.txt and thumbnail image. Follow CONTIBUTING.md for more details.
Please make the necessary changes.
|
This is better, just thumbnail.png is missing. Add that and then it's ready to merge! 🚀 |
|
All the required changes have been done. |
|
Hey @shingtesuyash, just create one thumbnail.png (not a folder) file having snapshot of the homepage. |
OctoplusNinja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @shingtesuyash, in the deployedLink.txt, just keep your deployed URL without any other text.
It should only have "https://mumbai-indians.herokuapp.com/" in the first line.
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also add a favicon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Keep contributing.
Thank you!
Please accept my PR.