Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Conversation

@shingtesuyash
Copy link
Contributor

Please accept my PR.

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for projects-showcase ready!

🔨 Explore the source changes: c33aebc

🔍 Inspect the deploy log: https://app.netlify.com/sites/projects-showcase/deploys/617bcb8ed401d300087f3040

😎 Browse the preview: https://deploy-preview-80--projects-showcase.netlify.app

@OctoplusNinja
Copy link
Member

@shingtesuyash use proper folder structure and add a deployedLink.txt and a thumbnail. Follow CONTIBUTING.md for details

Copy link
Member

@DevrajDC DevrajDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shingtesuyash , check your folder structure and also add a deployedLink.txt and thumbnail image. Follow CONTIBUTING.md for more details.
Please make the necessary changes.

@DevrajDC
Copy link
Member

This is better, just thumbnail.png is missing. Add that and then it's ready to merge! 🚀

@shingtesuyash
Copy link
Contributor Author

All the required changes have been done.

@OctoplusNinja
Copy link
Member

OctoplusNinja commented Oct 29, 2021

Hey @shingtesuyash, just create one thumbnail.png (not a folder) file having snapshot of the homepage.

Copy link
Member

@OctoplusNinja OctoplusNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @shingtesuyash, in the deployedLink.txt, just keep your deployed URL without any other text.
It should only have "https://mumbai-indians.herokuapp.com/" in the first line.

<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">

Copy link
Member

@thuongtruong1009 thuongtruong1009 Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also add a favicon.

Copy link
Member

@thuongtruong1009 thuongtruong1009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Keep contributing.
Thank you!

@OctoplusNinja OctoplusNinja merged commit 5a16a36 into Design-and-Code:main Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants