Skip to content

Vite migration and cypress tests #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stohrendorf
Copy link

Description

Migrates the build system to Vite, and adds Cypress tests to ensure future migrations don't break anything.

Additional Details

This focuses on test and build stuff only, which is already a big change, but should optimally not break anything.

Checklist

@stohrendorf stohrendorf marked this pull request as draft May 5, 2025 18:33
@owasp-dt-bot
Copy link

owasp-dt-bot commented May 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@stohrendorf stohrendorf force-pushed the vite branch 2 times, most recently from 1dde517 to 521b099 Compare May 13, 2025 05:28
@stevespringett
Copy link
Member

Much needed PR. Thank you. Are you planning to implement the SBOM generation in Vite as well? I think that was the missing piece preventing us from moving off of webpack.

@stohrendorf
Copy link
Author

Much needed PR. Thank you. Are you planning to implement the SBOM generation in Vite as well? I think that was the missing piece preventing us from moving off of webpack.

Currently, I'm just trying to make the tests work and give it a more or less decent coverage so that a migration to Vue 3 has less chance to break something.

@stohrendorf stohrendorf force-pushed the vite branch 3 times, most recently from 127e72b to 1453e95 Compare May 20, 2025 19:37
@VinodAnandan
Copy link

Hi @stohrendorf and @stevespringett, I wanted to share that there's a plugin called rollup-plugin-sbom which supports CycloneDX SBOM generation for Vite projects. Many thanks to @janbiasi, @boostvolt, and @xenobytezero for this project

@janbiasi
Copy link

Hi @stohrendorf and @stevespringett, I wanted to share that there's a plugin called rollup-plugin-sbom which supports CycloneDX SBOM generation for Vite projects. Many thanks to @janbiasi, @boostvolt, and @xenobytezero for this project

Hey @VinodAnandan, thanks for the mention! Please let me know if you're running into questions or need any kind of assistance :)

@stohrendorf
Copy link
Author

To whoever manually approves the workflow runs - the cypress tests currently hang with some tests, I'm currently working on this.

@nscuro
Copy link
Member

nscuro commented May 23, 2025

@stohrendorf I am trying to approve WF runs whenever I get notifications about changes here. If you are concerned about tests hanging, you can add timeout-minutes to the job that runs the tests. This is something we should do anyway for all workflows.

Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants