Add AND operator and enhance vulnerability handling in policy evaluations#5496
Open
arjavdongaonkar wants to merge 1 commit intoDependencyTrack:masterfrom
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2 tasks
…policy evaluations Signed-off-by: Arjav <arjavdongaonkar@gmail.com>
266aa61 to
3c73e01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The policy evaluation logic for ALL operator was aggregating condition matches at the component level, which allowed different vulnerabilities to satisfy different policy conditions. This resulted in false-positive policy violations because the system treated a policy as satisfied even when no single vulnerability matched all required conditions.
A new operator ("AND") is introduced to evaluate ALL conditions per vulnerability in AND way.
Each vulnerability is now checked independently, and a policy violation is created only when:
The same vulnerability triggers every policy condition defined in the policy.
During this change, PolicyViolation was extended to include a reference to the associated vulnerability.
Addressed Issue
#5490
Checklist