fix: codacy upload and JRE version #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
nscuro
reviewed
Feb 15, 2022
Co-authored-by: Niklas <nscuro@protonmail.com> Signed-off-by: K3rnelPan1c <69395733+k3rnelpan1c-dev@users.noreply.github.com>
k3rnelpan1c-dev
force-pushed
the
fix/codacy-upload
branch
from
503d972
to
cb54d43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR offers a fix for 2 mistakes I caused with my earlier packaging PR (#1303).
First it fixes the failing Codacy report upload, where I missed that it used to be downloaded in the 'Tool setup' step. It now uses the official Codacy GitHub action instead of the prior downloaded Jar.
Second it fixes a staging mishap that happened likely due to late local time 🤦♂️, where I already prepared a followup commit to bump the Container JRE to 17 as requested by the original review. With this PR I offer a revert to the 11 JRE.
Changes
Issues