Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new theme: youtube-dark #638

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

wamikabro
Copy link
Contributor

added youtube-dark theme for youtubers.

issue number #637

Type of change

theme

  • [✅] New feature (added a non-breaking change which adds functionality)

  • [✅] Updated documentation (updated the readme, templates, or other repo files)

  • [✅] I have checked to make sure no other pull requests are open for this issue

  • [✅] The code is properly formatted and is consistent with the existing code style

  • [✅] I have made corresponding changes to the documentation

  • [✅] My changes generate no new warnings

Screenshots

youtube-dark

@DenverCoder1
Copy link
Owner

Looks good 👍

It seems that there are some extra files on the branch that were added and not needed, would you be able to remove those?

@wamikabro
Copy link
Contributor Author

Looks good 👍

It seems that there are some extra files on the branch that were added and not needed, would you be able to remove those?

Sure. Let me look for them and remove.

@wamikabro
Copy link
Contributor Author

Looks good 👍

It seems that there are some extra files on the branch that were added and not needed, would you be able to remove those?

Is it alright now? I removed all the files that I could, still there are 2 files that I can not remove also I don't know what are they for. Or guide me if there's anything wrong.

@wamikabro
Copy link
Contributor Author

Okay I've removed all of them now. Have a look.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit ae2405c into DenverCoder1:main Jan 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants