Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added whatsapp-light2 and whatsapp-dark2 themes #619

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

FajarKim
Copy link
Contributor

@FajarKim FajarKim commented Nov 1, 2023

Description

Added whatsapp-light2 and whatsapp-dark2 themes (based on version WhatsApp 2.23.23.2)

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Theme Preview
whatsapp-light image
whatsapp-dark image

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Nov 2, 2023

Maybe instead of changing these we could create new themes like whatsapp-light2, whatsapp-dark2 so that it doesn't change what it looks like in case some people who are using the old ones want it to stay the same?

@FajarKim FajarKim changed the title fix: Update whatsapp-light and whatsapp-dark themes feat: Added whatsapp-light2 and whatsapp-dark2 themes Nov 4, 2023
@FajarKim
Copy link
Contributor Author

FajarKim commented Nov 4, 2023

Maybe instead of changing these we could create new themes like whatsapp-light2, whatsapp-dark2 so that it doesn't change what it looks like in case some people who are using the old ones want it to stay the same?

Yeah, okay then. I've changed it.

@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-main-slrvkzcm7mov November 5, 2023 14:38 Inactive
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 👍

@DenverCoder1 DenverCoder1 merged commit b909d38 into DenverCoder1:main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants